Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
L10n tests and better error handling #421
This is not a blocker, but something I'd like to add anyhow.
I find the naming of the methods confusing. You currently have:
Only the former two are specific to l10n (they pass / lookup keys), the latter two are generally applicable pattern substitution methods. Given the length of this chain, it's a bit odd to call
As a suggestion, the following might be more clear:
These tests do not pass on my machine. Have I misconfigured something perhaps? I ran
Turns out these don't pass in Java 6:
I'll look into it. Any ideas why?
referenced this pull request
Dec 29, 2015
When it breaks under Java 6 it's looking for the override file here: "/home/steve/freenet/fred/run/file:/usr/lib/jvm/java-6-openjdk-common/jre/lib/ext/pulse-java.jar!/../test/freenet/l10n/freenet.l10n.en.override.properties". When it works under Java 7 it's looking for "/home/steve/Documents/Coding/freenet/fred/build/main/../test/freenet/l10n/freenet.l10n.en.override.properties". Looks like the classLoaderDir cannot be assumed to be reasonable. I'll see what the other tests with files do.