Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix bug #6623 : Wrapper.log: Lots of "setNativePriority(X) has failed!" #435
Bug in question is https://bugs.freenetproject.org/view.php?id=6743
This fix is the same as the patch in https://bugs.freenetproject.org/view.php?id=6623 and as bertm says
I'd rather not merge a half-measure like this that just disables the logging.
Respectfully, @bertm is wrong :)
This is not a half-measure, it's the real fix. I'm the one who introduced the said buggy code and we've extensively discussed it with toad already.
The check behind the boolean doesn't make much sense (and yes it's also my code) and it definitely doesn't in this specific instance.
You all seem to be reading my comment out of context. This does not fix the logging behaviour bug 6623 reported, but does fix this particular source of the error (and adds Javadoc to hopefully prevent future instances). If NativeThreads are somehow disabled—i.e. Fred is reniced, which it shouldn't be, but heh—it will still spit out hundreds of
I do however agree that this fixes this particular instance where NativeThreads are disabled inappropriately, and give my full ack for merging.