New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DiffieHellman related code (pre-neg9) #439

Merged
merged 1 commit into from Dec 19, 2015

Conversation

Projects
None yet
3 participants
@nextgens
Copy link
Contributor

nextgens commented Dec 19, 2015

This has been dead code for a while now... It doesn't affect functionality and should be safe to merge as is.

I've just bootstrapped an opennet node with it (it has been tested).

Remove DiffieHellman related code (pre-neg9)
This has been dead code for a while now
@bertm

This comment has been minimized.

Copy link
Member

bertm commented Dec 19, 2015

This does break bootstrapping for pre-neg9 nodes to seednodes once they have updated. Do we consider that a problem? Those nodes are ancient anyhow, so that might not be a problem at all (I recall some recent discussion on this subject, but I don't know what the final consensus was).

Apart from the above, looks good to merge from reading, will test as well in a minute.

@Thynix

This comment has been minimized.

Copy link
Member

Thynix commented Dec 19, 2015

pre-neg9 nodes are years old and not worth maintaining (if we can call it that) this cruft for. It's putting in a lot of effort for non-users of the software. negtype 9 has been mandatory since 1448 went mandatory on July 23rd, 2013, and support for negtypes before 9 was disabled in build 1465, released on August 9th, 2014.

@bertm

This comment has been minimized.

Copy link
Member

bertm commented Dec 19, 2015

Alright! ☺

Bootstrapping tested OK, just as expected. This has my ack.

@Thynix Thynix merged commit 94afb8b into freenet:next Dec 19, 2015

@nextgens nextgens deleted the nextgens:crypto-cleanup branch Jan 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment