fix: strengthen self-connection guard to check pub_key #2144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
test_three_node_network_connectivitytest was failing in the release/v0.1.39 CI. This failure was caused by the interaction between PR #2140 (self-connection guard) and PR #2142 (response_target fix).Root cause: The self-connection guard in
should_accept()only checkedpeer_key, which can beNoneearly during node initialization. When the gateway received a connection request that referenced itself, the guard failed to trigger becauseget_peer_key()returnedNone.Investigation findings:
test_three_node_network_connectivitypassed ✅Solution
Add a secondary self-connection check that compares
pub_keydirectly, which is always available inConnectionManager:Testing
rejects_self_connection_by_pubkey_when_peer_key_not_settest_three_node_network_connectivitynow passes locallyFixes
This should unblock the release/v0.1.39 CI.
[AI-assisted - Claude]