From 2f94e17368531595be7c7c12b21096fed106cdec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alan=20Fern=C3=A1ndez=20Saavedra?= Date: Thu, 7 Aug 2025 16:35:46 +0200 Subject: [PATCH 1/2] fix: make label a required prop on timefield --- .../experimental/TimeField/TimeField.tsx | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/components/experimental/TimeField/TimeField.tsx b/src/components/experimental/TimeField/TimeField.tsx index d6eca5c6..cc0c67e3 100644 --- a/src/components/experimental/TimeField/TimeField.tsx +++ b/src/components/experimental/TimeField/TimeField.tsx @@ -1,5 +1,5 @@ import React from 'react'; -import { TimeValue } from 'react-aria'; +import { TimeValue, VisuallyHidden } from 'react-aria'; import { FieldError, TimeField as BaseTimeField, TimeFieldProps as BaseTimeFieldProps } from 'react-aria-components'; import { Label } from '../Field/Label'; import { Footer } from '../Field/Footer'; @@ -10,12 +10,17 @@ import { DateSegment } from '../Field/DateSegment'; import { Wrapper } from '../Field/Wrapper'; import { FieldProps } from '../Field/Props'; -type TimeFieldProps = FieldProps & BaseTimeFieldProps; +type TimeFieldProps = Omit & + BaseTimeFieldProps & { + label: string; + hideLabel?: boolean; + }; const TimeField = React.forwardRef( ( { label, + hideLabel = false, description, errorMessage, leadingIcon, @@ -32,8 +37,14 @@ const TimeField = React.forwardRef( <> {leadingIcon} - - {label && } + + {hideLabel ? ( + + + + ) : ( + + )} {segment => } {actionIcon} From f0e49ca53f256429622903621959cab478853f74 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alan=20Fern=C3=A1ndez=20Saavedra?= Date: Thu, 7 Aug 2025 16:48:22 +0200 Subject: [PATCH 2/2] fix: import --- src/components/experimental/TimeField/TimeField.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/components/experimental/TimeField/TimeField.tsx b/src/components/experimental/TimeField/TimeField.tsx index cc0c67e3..d453e180 100644 --- a/src/components/experimental/TimeField/TimeField.tsx +++ b/src/components/experimental/TimeField/TimeField.tsx @@ -1,5 +1,5 @@ import React from 'react'; -import { TimeValue, VisuallyHidden } from 'react-aria'; +import { TimeValue } from 'react-aria'; import { FieldError, TimeField as BaseTimeField, TimeFieldProps as BaseTimeFieldProps } from 'react-aria-components'; import { Label } from '../Field/Label'; import { Footer } from '../Field/Footer'; @@ -9,6 +9,7 @@ import { DateInput } from '../Field/Field'; import { DateSegment } from '../Field/DateSegment'; import { Wrapper } from '../Field/Wrapper'; import { FieldProps } from '../Field/Props'; +import { VisuallyHidden } from '../../VisuallyHidden/VisuallyHidden'; type TimeFieldProps = Omit & BaseTimeFieldProps & {