New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert blocksize increase handling to be proportional reduction #1599

Merged
merged 1 commit into from Jun 13, 2017

Conversation

Projects
2 participants
@Dilvish-fo
Member

Dilvish-fo commented Jun 6, 2017

If the blocksize of a production queue build item is increased, reduce the progress in proportion to the increase. This essentially reverts a recent change (which seems like it might have accidentally slipped into c6cc240 since the commit message makes no mention of it), and fixes #1574

Per discussion at http://www.freeorion.org/forum/viewtopic.php?p=89017#p89017

Revert blocksize increase handling to be proportional reduction
If the blocksize of a production queue build item is increased, reduce the progress in proportion to the increase

fixes #1574

@Vezzra Vezzra added the category:bug label Jun 11, 2017

@Vezzra Vezzra added this to the v0.4.8 milestone Jun 11, 2017

@Vezzra

Vezzra approved these changes Jun 11, 2017

Didn't test, but looks ok.

@Dilvish-fo Dilvish-fo merged commit d8d2837 into freeorion:master Jun 13, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Dilvish-fo Dilvish-fo deleted the Dilvish-fo:revert_blocksize_increase_handling branch Jun 13, 2017

@Vezzra Vezzra added this to Proposed in 0.4.7.1 Bugfix Release Aug 11, 2017

MatGB added a commit to MatGB/freeorion that referenced this pull request Aug 15, 2017

Revert blocksize increase handling to be proportional reduction (free…
…orion#1599)

If the blocksize of a production queue build item is increased, reduce the progress in proportion to the increase

fixes freeorion#1574

@Vezzra Vezzra moved this from Proposed to Accepted in 0.4.7.1 Bugfix Release Aug 20, 2017

@Vezzra Vezzra modified the milestones: 0.4.7.1 Bugfix Release, v0.4.8 Aug 20, 2017

Vezzra added a commit to Vezzra/freeorion that referenced this pull request Aug 20, 2017

Revert blocksize increase handling to be proportional reduction (free…
…orion#1599)

If the blocksize of a production queue build item is increased, reduce the progress in proportion to the increase

fixes freeorion#1574

Vezzra added a commit that referenced this pull request Aug 24, 2017

Revert blocksize increase handling to be proportional reduction (#1599)
If the blocksize of a production queue build item is increased, reduce the progress in proportion to the increase

fixes #1574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment