Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use BOOST_OPTIONAL_CONFIG_USE_OLD_IMPLEMENTATION_OF_OPTIONAL with Boost >= 1.67 #2214

Merged
merged 1 commit into from Jul 14, 2018

Conversation

Projects
4 participants
@jbeich
Copy link
Contributor

commented Jul 14, 2018

boost#12349 is fixed, so the workaround can go away. According to Repology many distros still ship Boost >= 1.60, < 1.67.

FreeOrion 0.4.8-rc1 with the patch here build logs:

@jbeich jbeich changed the title Don't use BOOST_OPTIONAL_CONFIG_USE_OLD_IMPLEMENTATION_OF_OPTIONAL with Boost >= 1.67тг Don't use BOOST_OPTIONAL_CONFIG_USE_OLD_IMPLEMENTATION_OF_OPTIONAL with Boost >= 1.67 Jul 14, 2018

@geoffthemedio geoffthemedio requested a review from adrianbroher Jul 14, 2018

@adrianbroher

This comment has been minimized.

Copy link
Contributor

commented Jul 14, 2018

Looks good to me.

@Vezzra please consider for v0.4.8 cherry-pick.

@adrianbroher adrianbroher merged commit a5eae27 into freeorion:master Jul 14, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Vezzra Vezzra added this to the v0.4.8 (optional) milestone Jul 17, 2018

@Vezzra Vezzra added this to Proposed in 0.4.8 Release Jul 17, 2018

@Vezzra Vezzra moved this from Proposed to Accepted in 0.4.8 Release Jul 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.