Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix wrong/haphazard instant-blockades of monster fleets #2220
by having unowned fleets move before owned (empire) fleets
I think that in the past, to the extent that I noticed this kind of situation and blockade, I had lumped it together with a second kind of situation, where an empire fleet and a monster fleet both arrive at the same time, which results (and still results under this PR) in the monster fleet being blockaded. But then I realized that the blockades in the first situation were uncertain/haphazard and depended entirely on which fleet happened to get processed first, which the player doesn't know in advance.
Example-- in the below screenshot and savegame, a larval kraken is set to leave Asterly on the same turn that a Frigate is due to arrive there; without this PR it happens that in this particular case (at least on my machine) the Frigate's movement is processed first and the kraken is insta-blockaded and not allowed to leave.
I also think that this fix is a safe one, and worth putting into 0.4.8 RC3