Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify players that eliminated empire finished its orders #2403

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
3 participants
@o01eg
Copy link
Contributor

o01eg commented Mar 8, 2019

No description provided.

@o01eg o01eg force-pushed the o01eg:eliminated-empire-ready branch from fa9a0f4 to 9ced0db Mar 8, 2019

@Vezzra Vezzra added this to the Next Release milestone Mar 8, 2019

@@ -1744,6 +1744,16 @@ bool ServerApp::EliminatePlayer(const PlayerConnectionPtr& player_connection) {
// break link between player and empire
m_player_empire_ids.erase(player_id);

// notify other player that this empire finished orders

This comment has been minimized.

@geoffthemedio

geoffthemedio Mar 8, 2019

Member

Could you clarify why this is useful and how it works? Does the eliminated player just stay in waiting mode on the other players' clients, for the rest of the session, or until the eliminated player disconnects? Are they disconnected automatically at some point? Is there any remaining empire to player connection after the elimination happens?

This comment has been minimized.

@o01eg

o01eg Mar 8, 2019

Author Contributor

There only change is to show other player that eliminated empire made its choice.

Could you clarify why this is useful and how it works?

Currently other player see waiting status of eliminated empire until turn advance. They could think player of eliminated empire made its turn too long and postpone their turns as well.

Does the eliminated player just stay in waiting mode on the other players' clients, for the rest of the session, or until the eliminated player disconnects?

On turn advance other player will get elimination sitrep and this empire get elimination mark in the empires' list.

Are they disconnected automatically at some point?

No, but they stopped to get turn updates and to act in the game.

Is there any remaining empire to player connection after the elimination happens?

No, link between empire and player is erased after elimination.

This comment has been minimized.

@geoffthemedio

geoffthemedio Mar 8, 2019

Member

could you then clarify in the comment why this is being done?

This comment has been minimized.

@o01eg

o01eg Mar 8, 2019

Author Contributor

Added more commentary.

@o01eg o01eg force-pushed the o01eg:eliminated-empire-ready branch from 9ced0db to 394eccf Mar 8, 2019

@geoffthemedio geoffthemedio merged commit fd566bc into freeorion:master Mar 8, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@o01eg o01eg deleted the o01eg:eliminated-empire-ready branch Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.