Improve AnyInstanceMethod#hide_original_method #262
referenced this pull request
Sep 14, 2016
Very minor: I think it would be clearer to change the 2nd commit subject line from:
"Use prepended module to stub any instance methods in Ruby 2+"
"Use prepended module to stub any_instance methods in Ruby 2+
"Use prepended module to stub AnyInstance methods in Ruby 2+"
.... oh boy ... found a 'bug' ... but honestly we use pretty funky code :)
... I can somehow work around that most likely ... just FYI that this changes ancestors ...
Thanks for running your tests. Using the prepended module approach (to intercept calls to a method) as the default approach in later versions of Ruby feels like a more elegant solution. However, I take your point that it does mean the temporary addition of a module to the ancestor chain.
I'm happy that the change to the ancestor chain ought not cause problems for idiomatic/duck-typing code. Are you happy with this justification? We'd be happy to try to help fix your code to avoid the problem.
Did you see any other test failures? Are you otherwise happy for the latest code in master to be released?
Oct 10, 2016
thx for fixing, already bumped :D
On Mon, Oct 10, 2016 at 8:18 AM, James Mead firstname.lastname@example.org