Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Branch: master
Commits on May 15, 2012
  1. @chrisroos

    Add .travis.yml.

    chrisroos authored
    We used to test this project using Jenkins on our own CI Server.  I want
    to get rid of Jenkins so I'm hoping to move the responsbility of testing
    this project to Travis.
Commits on Apr 20, 2011
  1. @chrisroos

    Merge branch 'master' of

    chrisroos authored
    I toyed with the idea of rebasing our commits on top of raykrueger/master but decided against it in the end.  Not necessarily for any good reason other than that I didn't want to have to force push our master.
    We'll want to refactor the transmitter to remove some of the duplication between that and smpp/base.rb (that was refactored in 7f6c01e).
Commits on Apr 15, 2011
  1. @chrisroos-and-floehopper

    Simplified UDH decoding by using a 16-bit integer unpack format for t…

    chrisroos-and-floehopper authored
    …he message_id in the case of the 6-octet UDH.
    In this way the @udh array always has the same number of elements whether the UDH is in the 5 or 6 octet form.
    We changed the expected values in the assertions checking the decoded UDH values to use hex values so they can be related to the raw hex values above.
  2. @chrisroos-and-floehopper

    Avoid cluttering up test output with debug logging.

    chrisroos-and-floehopper authored
    The test we've deleted didn't have any assertions, was called "not a real test", and seemed almost identical to the test below it.
  3. @chrisroos-and-floehopper

    Introduce a test_helper and change the logger used during the tests s…

    chrisroos-and-floehopper authored
    …o it doesn't clutter up the test output.
  4. @chrisroos-and-floehopper
  5. @chrisroos-and-floehopper
  6. @chrisroos-and-floehopper
  7. @chrisroos @chrisroos-and-floehopper

    Handle UCS2 messages where the first byte of the short_message happen…

    chrisroos authored chrisroos-and-floehopper committed
    …s to be either 5 or 6.
Commits on Apr 13, 2011
  1. @chrisroos-and-floehopper
Commits on Apr 1, 2011
  1. @floehopper

    A DeliverSm PDU can have a longer header which includes a 2-octet mes…

    floehopper authored
    …sage ID instead of the usual 1-octet.
    The tests I've added are based on real messages, but with anonymized MSISDNs and content - hopefully the raw data is still in a consistent form.
    It looks like there may be similar shortcomings in the SubmitSm PDU code, but I haven't addressed these.
  2. @floehopper
Commits on Mar 31, 2011
  1. @tomafro

    We regret trying to add encoding logic into the DeliverSm class

    tomafro authored
    Due to significant divergence from the SMPP spec, the encoding logic was becoming complex and SMSC specific.  We've therefore moved this logic into our own application, where it seems to more naturally fit.
Commits on Mar 28, 2011
  1. @tomafro
Commits on Mar 24, 2011
  1. @kalv

    left in a print statement

    kalv authored
  2. @kalv
Commits on Mar 9, 2011
  1. @floehopper

    I had incorrectly assumed the message_id supplied to Transmitter#send…

    floehopper authored
    …_mt was the same as the PDU sequence number.
  2. @floehopper

    Added a basic Transmitter class.

    floehopper authored
    We need one of these because our SMSC doesn't accept connections from a Transceiver.
    Only includes only *very* basic handling of SubmitSmResponse PDUs.
    Added basic test coverage for Transmitter class.
  3. @kalv @floehopper

    Adding spiked code used to test a transmitter connection

    kalv authored floehopper committed
  4. @floehopper
Commits on Mar 2, 2011
  1. @tomafro
  2. @tomafro

    Default encoding should be used on any message where the 2nd and 3rd …

    tomafro authored
    …data coding bits are not set.
Commits on Feb 25, 2011
  1. @tomafro

    Handle messages with data_coding of 1

    tomafro authored
    Some messages were found with data_coding of 1.  Although some specs state that this means they are encoded as ASCII, when dealing with O2 SMSCs, bits 2 and 3 of the data_coding are used to indicate encoding.  If they are both set to 0 then this indicates default character set, in our case HP-ROMAN8
Commits on Feb 16, 2011
  1. @lazyatom

    Some final tweaks and a more rounded test using actual SMSC data.

    lazyatom authored
    I got the code for the circumflex character wrong.
  2. @lazyatom
  3. @lazyatom

    Convert UCS-2 (UTF-16BE) messages into the standard UTF-8.

    lazyatom authored
    These messages come in with data coding '8'.
  4. @lazyatom

    Handle GSM escaped characters like euro, curly brackets and tilde.

    lazyatom authored
    Because these come with an escape character and then an ASCII character, we substitute it for the appropriate ROMAN-8 coding.
    The euro character is a special case, since there is no ROMAN-8 encoding for this character. In this case we simply insert a very unlikely token string, and then replace it after the UTF-8 conversion has occurred.
  5. @lazyatom

    Message bodies with non-ASCII characters are encoded using HP-ROMAN8.

    lazyatom authored
    We want UTF-8 in our application, so let's convert it using Iconv.
    We should remember that we've hard-coded the character set that is in use on SMSCs for historical reasons, but this may not be the case on all SMSCs.
Commits on Feb 14, 2011
  1. @floehopper-and-kalv
Commits on Oct 25, 2010
  1. @kalv
  2. @kalv
  3. @kalv

    Handle multi part messages.

    kalv authored
    Can now handle 5 bit header information being sent in the body of the message.
    To fully support all types of mobile concatenated messages, the ability to handle 8 bit body headers will need to be implemented. At the moment this difficult as we require an example message with a 8 bit header.
Commits on Sep 13, 2010
  1. @floehopper
  2. @floehopper
  3. @floehopper

    Remove methods for sending SMSes.

    floehopper authored
    Also change messages, comments, etc to reflect Receiver class.
Something went wrong with that request. Please try again.