Permalink
Commits on May 15, 2012
  1. Add .travis.yml.

    We used to test this project using Jenkins on our own CI Server.  I want
    to get rid of Jenkins so I'm hoping to move the responsbility of testing
    this project to Travis.
    chrisroos committed May 15, 2012
Commits on Apr 20, 2011
  1. Merge branch 'master' of https://github.com/raykrueger/ruby-smpp

    I toyed with the idea of rebasing our commits on top of raykrueger/master but decided against it in the end.  Not necessarily for any good reason other than that I didn't want to have to force push our master.
    
    We'll want to refactor the transmitter to remove some of the duplication between that and smpp/base.rb (that was refactored in 7f6c01e).
    chrisroos committed Apr 20, 2011
Commits on Apr 15, 2011
  1. Simplified UDH decoding by using a 16-bit integer unpack format for t…

    …he message_id in the case of the 6-octet UDH.
    
    In this way the @udh array always has the same number of elements whether the UDH is in the 5 or 6 octet form.
    
    We changed the expected values in the assertions checking the decoded UDH values to use hex values so they can be related to the raw hex values above.
    chrisroos-and-floehopper committed Apr 15, 2011
  2. Avoid cluttering up test output with debug logging.

    The test we've deleted didn't have any assertions, was called "not a real test", and seemed almost identical to the test below it.
    chrisroos-and-floehopper committed Apr 15, 2011
  3. Introduce a test_helper and change the logger used during the tests s…

    …o it doesn't clutter up the test output.
    chrisroos-and-floehopper committed Apr 15, 2011
Commits on Apr 13, 2011
Commits on Apr 1, 2011
  1. A DeliverSm PDU can have a longer header which includes a 2-octet mes…

    …sage ID instead of the usual 1-octet.
    
    The tests I've added are based on real messages, but with anonymized MSISDNs and content - hopefully the raw data is still in a consistent form.
    
    It looks like there may be similar shortcomings in the SubmitSm PDU code, but I haven't addressed these.
    floehopper committed Mar 30, 2011
Commits on Mar 31, 2011
  1. We regret trying to add encoding logic into the DeliverSm class

    Due to significant divergence from the SMPP spec, the encoding logic was becoming complex and SMSC specific.  We've therefore moved this logic into our own application, where it seems to more naturally fit.
    tomafro committed Mar 31, 2011
Commits on Mar 28, 2011
Commits on Mar 24, 2011
  1. left in a print statement

    kalv committed Mar 24, 2011
Commits on Mar 9, 2011
  1. I had incorrectly assumed the message_id supplied to Transmitter#send…

    …_mt was the same as the PDU sequence number.
    floehopper committed Mar 9, 2011
  2. Added a basic Transmitter class.

    We need one of these because our SMSC doesn't accept connections from a Transceiver.
    
    Only includes only *very* basic handling of SubmitSmResponse PDUs.
    
    Added basic test coverage for Transmitter class.
    floehopper committed Mar 9, 2011
Commits on Mar 2, 2011
  1. Default encoding should be used on any message where the 2nd and 3rd …

    …data coding bits are not set.
    tomafro committed Mar 2, 2011
Commits on Feb 25, 2011
  1. Handle messages with data_coding of 1

    Some messages were found with data_coding of 1.  Although some specs state that this means they are encoded as ASCII, when dealing with O2 SMSCs, bits 2 and 3 of the data_coding are used to indicate encoding.  If they are both set to 0 then this indicates default character set, in our case HP-ROMAN8
    tomafro committed Feb 25, 2011
Commits on Feb 16, 2011
  1. Some final tweaks and a more rounded test using actual SMSC data.

    I got the code for the circumflex character wrong.
    lazyatom committed Feb 16, 2011
  2. Convert UCS-2 (UTF-16BE) messages into the standard UTF-8.

    These messages come in with data coding '8'.
    lazyatom committed Feb 16, 2011
  3. Handle GSM escaped characters like euro, curly brackets and tilde.

    Because these come with an escape character and then an ASCII character, we substitute it for the appropriate ROMAN-8 coding.
    
    The euro character is a special case, since there is no ROMAN-8 encoding for this character. In this case we simply insert a very unlikely token string, and then replace it after the UTF-8 conversion has occurred.
    lazyatom committed Feb 16, 2011
  4. Message bodies with non-ASCII characters are encoded using HP-ROMAN8.

    We want UTF-8 in our application, so let's convert it using Iconv.
    
    We should remember that we've hard-coded the character set that is in use on SMSCs for historical reasons, but this may not be the case on all SMSCs.
    lazyatom committed Feb 16, 2011
Commits on Feb 14, 2011
Commits on Oct 25, 2010
  1. Handle multi part messages.

    Can now handle 5 bit header information being sent in the body of the message.
    
    To fully support all types of mobile concatenated messages, the ability to handle 8 bit body headers will need to be implemented. At the moment this difficult as we require an example message with a 8 bit header.
    kalv committed Oct 25, 2010
Commits on Sep 13, 2010
  1. Remove methods for sending SMSes.

    Also change messages, comments, etc to reflect Receiver class.
    floehopper committed Sep 13, 2010