New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support implicit args in @tagless abstract methods #403

Closed
rafaparadela opened this Issue Oct 2, 2017 · 5 comments

Comments

Projects
None yet
7 participants
@rafaparadela
Member

rafaparadela commented Oct 2, 2017

No description provided.

@rafaparadela rafaparadela added this to the Sprint 7 milestone Oct 2, 2017

@anamariamv anamariamv removed this from the Sprint 7 milestone Oct 4, 2017

@fedefernandez fedefernandez added the spree label Oct 26, 2017

@enricsangra

This comment has been minimized.

Show comment
Hide comment
@enricsangra

enricsangra Oct 29, 2017

Is it possible to have a test to understand the specifics of the problem?

enricsangra commented Oct 29, 2017

Is it possible to have a test to understand the specifics of the problem?

@raulraja

This comment has been minimized.

Show comment
Hide comment
@raulraja

raulraja Nov 5, 2017

Contributor

@rafaparadela can you provide @enricsangra with a reduced case that reproduces the error?

Contributor

raulraja commented Nov 5, 2017

@rafaparadela can you provide @enricsangra with a reduced case that reproduces the error?

@juanpedromoreno

This comment has been minimized.

Show comment
Hide comment
@juanpedromoreno

juanpedromoreno Jan 8, 2018

Contributor

This would be the ignored test reproducing this issue:

"a trait with some implicit parameters, with many params lists" ignore {

Contributor

juanpedromoreno commented Jan 8, 2018

This would be the ignored test reproducing this issue:

"a trait with some implicit parameters, with many params lists" ignore {

@juanpedromoreno

This comment has been minimized.

Show comment
Hide comment
@juanpedromoreno

juanpedromoreno Jan 8, 2018

Contributor

It might be handy to have another test for this case:

trait Generic[A]

"a trait with some implicit generic parameter, with standard params" ignore {
  "@tagless trait X { def f[T](a: Int)(implicit b: Generic[T]): FS[Int] }" should compile
}
Contributor

juanpedromoreno commented Jan 8, 2018

It might be handy to have another test for this case:

trait Generic[A]

"a trait with some implicit generic parameter, with standard params" ignore {
  "@tagless trait X { def f[T](a: Int)(implicit b: Generic[T]): FS[Int] }" should compile
}
@diesalbla

This comment has been minimized.

Show comment
Hide comment
@diesalbla

diesalbla Mar 27, 2018

Contributor

This issue has been implemented recently. There is a test here.

Contributor

diesalbla commented Mar 27, 2018

This issue has been implemented recently. There is a test here.

@diesalbla diesalbla closed this Mar 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment