Remove dependency on luci-base, introduce gluon-web as new base for Config Mode #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belzebub40k
added a commit
to freifunk-mwu/site-ffmwu
that referenced
this pull request
Feb 8, 2017
… as it breaks images for 4MB devices freifunk-gluon/gluon#1007
neocturne
changed the title
neocturne
force-pushed
the
noluci
branch
2 times, most recently
from
6bdad7b
to
e95f77a
Compare
As convenient as the Map is, the underlying code is very complex and will be removed.
neocturne
force-pushed
the
noluci
branch
2 times, most recently
from
a431985
to
e90c0de
Compare
The gluon-web package is basically a stripped-down and refactored version of the LuCI base.
|
I've decided to postpone the CSRF protection and get this merged. No released version of Gluon has CSRF protection, so this isn't a regression (I'll still try to add this before Gluon 2017.1). |
adlerweb
added a commit
to FreifunkMYK/site-ffmyk
that referenced
this pull request
Feb 22, 2017
Migration gluon-web as per freifunk-gluon/gluon#1007
belzebub40k
added a commit
to freifunk-mwu/site-ffmwu
that referenced
this pull request
Feb 24, 2017
belzebub40k
added a commit
to freifunk-mwu/site-ffmwu
that referenced
this pull request
Feb 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
luci-base is huge (> 100KB compressed), and we only use a small subset of it. LuCI base translations take up >20KB / language.
Gluon packages are converted from using luci.model.uci to uci-simple, remaining uses luci-base libraries outside of the config mode are removed.
LuCI is replaced with a stripped-down version "gluon-web" without features we don't need; in addition, it has been refactored significantly to make it more maintainable.
gluon-web has a base size of about 19KB. The total per-language overhead for all packages in the Gluon repository is less than 4KB. In total, this PR reduces the rootfs size for a typical build with en and de languages by about 140KB.
To accommodate the removal of LuCI, all luci-admin- packages have been renamed:
Testing of the new config wizard/advanced settings is very welcome. The following points should be completed before merging: