ar71xx: flag FritzBox 4020 buttons as active low #1544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buttons of AVM FritzBox 4020 are incorrectly flagged as active high. This was an oversight as RFKill button was working as expected even with incorrectly flagged GPIO. Config mode is still accessable but will start on any button press, not only for the ones >= 10 seconds. This commit corrects this behavior to the expected one (10 second long press necessary to enter config mode).
|
I cherry-picked the commit to openwrt-18.06, so our next update will contain the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request for the current Gluon stable branch. It is not against Gluon master as @NeoRaider might want to consider cherry-picking this commit for the openwrt-18.06 branch, making a downstream patch obsolete.
Buttons of AVM FritzBox 4020 are incorrectly flagged as active high.
This was an oversight as RFKill button was working as expected even
with incorrectly flagged GPIO.
Config mode is still accessable but will start on any button press, not
only for the ones >= 10 seconds.
This commit corrects this behavior to the expected one (10 second long
press necessary to enter config mode).