Skip to content

v2018.1.x: kernel: collect module symvers for external modules #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ecsv
Copy link
Contributor

@ecsv ecsv commented Nov 23, 2018

Collect module symvers for all external modules to make them available
for modpost. This fixes dependencies for most external modules.

root@ffv-525400123456:/# modinfo batman-adv
module:         /lib/modules/4.4.153/batman-adv.ko
alias:          net-pf-16-proto-16-family-batadv
alias:          rtnl-link-batadv
version:        openwrt-2018.1-5
description:    B.A.T.M.A.N. advanced
author:         Marek Lindner <mareklindner@neomailbox.ch>, Simon Wunderlich <sw@simonwunderlich.de>
license:        GPL
depends:

After:

root@ffv-525400123456:/# modinfo batman-adv
module:         /lib/modules/4.4.153/batman-adv.ko
alias:          net-pf-16-proto-16-family-batadv
alias:          rtnl-link-batadv
version:        openwrt-2018.1-5
description:    B.A.T.M.A.N. advanced
author:         Marek Lindner <mareklindner@neomailbox.ch>, Simon Wunderlich <sw@simonwunderlich.de>
license:        GPL
depends:        libcrc32c,cfg80211

Collect module symvers for all external modules to make them available
for modpost. This fixes dependencies for most external modules.

  root@ffv-525400123456:/# modinfo batman-adv
  module:         /lib/modules/4.4.153/batman-adv.ko
  alias:          net-pf-16-proto-16-family-batadv
  alias:          rtnl-link-batadv
  version:        openwrt-2018.1-5
  description:    B.A.T.M.A.N. advanced
  author:         Marek Lindner <mareklindner@neomailbox.ch>, Simon Wunderlich <sw@simonwunderlich.de>
  license:        GPL
  depends:

After:

  root@ffv-525400123456:/# modinfo batman-adv
  module:         /lib/modules/4.4.153/batman-adv.ko
  alias:          net-pf-16-proto-16-family-batadv
  alias:          rtnl-link-batadv
  version:        openwrt-2018.1-5
  description:    B.A.T.M.A.N. advanced
  author:         Marek Lindner <mareklindner@neomailbox.ch>, Simon Wunderlich <sw@simonwunderlich.de>
  license:        GPL
  depends:        libcrc32c,cfg80211
@rotanid rotanid added the 0. type: bug This is a bug label Nov 24, 2018
@rubo77
Copy link
Contributor

rubo77 commented Nov 24, 2018

When was this bug introduced?

@ecsv
Copy link
Contributor Author

ecsv commented Nov 24, 2018

It was triggered by 0bb3742 (which moved the the openwrt-routing feed to a newer commit in the openwrt-18.06 branch). The first gluon release with these commit is v2018.1.2.

The underlying bug (missing dependencies in external kernel modules) is there since the beginning of external kernel modules in LEDE/OpenWrt. Kernel modules before OpenWrt 18.06 usually used workarounds to force loading other kernel modules in the correct order. This kind of WAR was dropped for batman-adv in the openwrt-18.06 branch and its kernel loading mechanism was switched to AutoProbe.

The fix here is a backport of the required OpenWrt-18.06 commit to LEDE 17.01. It is required because gluon uses the openwrt-18.06 branch of openwrt-routing with LEDE 17.01.

@rotanid
Copy link
Member

rotanid commented Nov 24, 2018

@collimas reported it as working, merging it.
there should be more testers thought, at least one, before we consider a new bugfix release

@rotanid rotanid merged commit 8647b78 into freifunk-gluon:v2018.1.x Nov 24, 2018
@heini66
Copy link
Contributor

heini66 commented Nov 24, 2018

my er-x is working with this patch and i've got a bat0 interface

@ecsv ecsv deleted the batadv-kmod-deps/v2018.1.x branch November 24, 2018 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. type: bug This is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants