Config-Mode UI for Interface Role Assignment (v2)

[lemoer]

This PR is a second attempt to bring flexible role assignment for network interfaces into the config mode UI.

Implemented Features:

• The roles "Uplink", "Mesh" and "Client" can be assigned to interfaces.
• Roles can also be assigned to additional interfaces (beyond lan/wan/single).
• The roles "Uplink"/"Mesh" and "Client" are mutually exclusive.

Current Limitations:

• As of now, additional interfaces (eth, vlan, ...) have to be created manually from CLI.
• Assigning different roles to individual LAN/WAN ports is also only possible from CLI.

Once this PR is merged, follow-up PRs will remove the limitations and extend the functionality.

This is an example how the UI look with this PR:

Additional interfaces (beyond lan/wan/single) are handled correctly:

Some references:

• This PR builds upon the flexible role assignment from (Regenerate network and system UCI configs on every reconfigure, switch to role-based interface configuration #2372).
• This PR picks up some the wishes from (Wishlist: Config-Mode UI for Interface Roles Feature  #2393).
• The is a sucessor of the PR (Config-Mode UI for Interface Role Assignment #2480), which was abandonned since it introduced to many features at once.
• The functionality will be expanded in future PRs.

[lemoer]

(This PR is ready for review.)

[mkg20001]

This is being used successfully in the grazer mesh

[lemoer]

Before this PR, the mesh on lan checkbox added the mesh role in addition to the client role. We (in contrast) replace the client role with the mesh role.

This means that when mesh on lan was previously enabled, the config looks like this:

config interface 'iface_lan'
	option name '/lan'
	list role 'client'
	list role 'mesh'

When you open this config in the UI, it looks like this:

This means that the user intent is incorrectly shown. The user intent was: mesh, but client is shown.

After pressing save, the config looks like this:

config interface 'iface_lan'
	option name '/lan'
	list role 'client'

This means that the user intent has accidentially changed.

This is not good and should be avoided using an upgrade script.

[lemoer]

• TODO: Modify an upgrade script.
• TODO: Edit command line admin wiki page. (after merge)
• TODO: Edit suggestion for site.conf.

[lemoer]

Rebased.

[AiyionPrime]

Are we not still using the client interface to determine on which port to deliver the config-mode?

This allows users to get rid of all client interfaces, not the way, where its still there and just overridden by another role, but gone completely, no?

That way this PR would enable users to lock themselves out of their router for good?

edit we are not. Just tested it.

[AiyionPrime]

Not a complete review, but only the results of me checking for affected PRs in #2765.

It`s already adressed.

It's addressed.

[lemoer]

@neoraider gave his ack for everything except for the changes to the javascript code. He will keep a browser tab open to review the javascript code.

[Djfe]

Just a suggestion:
We could make the disabled checkboxes clickable. Clicking a disabled checkbox will uncheck and disable other checkbox(es) (in the same row) which are (mutually) exclusive to the one that was clicked.

[lemoer]

@Djfe I would like to get this PR merged as it is. It's been around for long enough. I will not delay it even further by adding additional features which need to be reviewed again.

Feel free to open a PR including your suggestions once this is megred.

[Djfe]

I agree. I don't want to delay this PR with my suggestion.

It's addressed.

[lemoer]

Thanks for the reviews I addressed all suggestions.

[Djfe]

awesome! Thanks for your work @lemoer ❤️