New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openwrt: Remove extra soc check in ath79_gpio_output_select #965

Merged
merged 1 commit into from Dec 5, 2016

Conversation

Projects
None yet
2 participants
@ecsv
Contributor

ecsv commented Dec 5, 2016

The assignment of the gpio_count and reg_base in ath79_gpio_output_select
takes care that only supported platforms can use ath79_gpio_output_select.
But the rebase of the patches after the last OpenWrt base update
accidentally added an extra check for the SoC which was missing support
soc_is_qca955x().

Boots on QCA955X devices which were using ath79_gpio_output_select ended
with an

Kernel bug detected[#1]:
[...]
Call Trace:
[<803e6174>] ath79_gpio_output_select+0x30/0xe8
[<803ed590>] om5p_acv2_setup+0x24/0x200
[<803e4dc0>] ath79_setup+0x28/0x38
[<80069ac8>] do_one_initcall+0x148/0x1ec
[<803e2cc4>] kernel_init_freeable+0x150/0x208
[<80065218>] kernel_init+0x10/0x114
[<80060878>] ret_from_kernel_thread+0x14/0x1c

Fixes: a22c1d5 ("Update OpenWrt base")
Signed-off-by: Sven Eckelmann sven@narfation.org

openwrt: Remove extra soc check in ath79_gpio_output_select
The  assignment of the gpio_count and reg_base in ath79_gpio_output_select
takes care that only supported platforms can use ath79_gpio_output_select.
But the rebase of the patches after the last OpenWrt base update
accidentally added an extra check for the SoC which was missing support
soc_is_qca955x().

Boots on QCA955X devices which were using ath79_gpio_output_select stopped
with

    Kernel bug detected[#1]:
    [...]
    Call Trace:
    [<803e6174>] ath79_gpio_output_select+0x30/0xe8
    [<803ed590>] om5p_acv2_setup+0x24/0x200
    [<803e4dc0>] ath79_setup+0x28/0x38
    [<80069ac8>] do_one_initcall+0x148/0x1ec
    [<803e2cc4>] kernel_init_freeable+0x150/0x208
    [<80065218>] kernel_init+0x10/0x114
    [<80060878>] ret_from_kernel_thread+0x14/0x1c

Fixes: a22c1d5 ("Update OpenWrt base")
Signed-off-by: Sven Eckelmann <sven@narfation.org>

@NeoRaider NeoRaider merged commit eed79bc into freifunk-gluon:master Dec 5, 2016

NeoRaider added a commit that referenced this pull request Dec 5, 2016

openwrt: Remove extra soc check in ath79_gpio_output_select (#965)
The  assignment of the gpio_count and reg_base in ath79_gpio_output_select
takes care that only supported platforms can use ath79_gpio_output_select.
But the rebase of the patches after the last OpenWrt base update
accidentally added an extra check for the SoC which was missing support
soc_is_qca955x().

Boots on QCA955X devices which were using ath79_gpio_output_select stopped
with

    Kernel bug detected[#1]:
    [...]
    Call Trace:
    [<803e6174>] ath79_gpio_output_select+0x30/0xe8
    [<803ed590>] om5p_acv2_setup+0x24/0x200
    [<803e4dc0>] ath79_setup+0x28/0x38
    [<80069ac8>] do_one_initcall+0x148/0x1ec
    [<803e2cc4>] kernel_init_freeable+0x150/0x208
    [<80065218>] kernel_init+0x10/0x114
    [<80060878>] ret_from_kernel_thread+0x14/0x1c

Fixes: a22c1d5 ("Update OpenWrt base")
Signed-off-by: Sven Eckelmann <sven@narfation.org>

@ecsv ecsv deleted the FreifunkVogtland:ecsv/om5pacv2-regression-fix branch Dec 5, 2016

ecsv added a commit to FreifunkVogtland/gluon that referenced this pull request Dec 5, 2016

openwrt: Remove extra soc check in ath79_gpio_output_select (freifunk…
…-gluon#965)

The  assignment of the gpio_count and reg_base in ath79_gpio_output_select
takes care that only supported platforms can use ath79_gpio_output_select.
But the rebase of the patches after the last OpenWrt base update
accidentally added an extra check for the SoC which was missing support
soc_is_qca955x().

Boots on QCA955X devices which were using ath79_gpio_output_select stopped
with

    Kernel bug detected[#1]:
    [...]
    Call Trace:
    [<803e6174>] ath79_gpio_output_select+0x30/0xe8
    [<803ed590>] om5p_acv2_setup+0x24/0x200
    [<803e4dc0>] ath79_setup+0x28/0x38
    [<80069ac8>] do_one_initcall+0x148/0x1ec
    [<803e2cc4>] kernel_init_freeable+0x150/0x208
    [<80065218>] kernel_init+0x10/0x114
    [<80060878>] ret_from_kernel_thread+0x14/0x1c

Fixes: a22c1d5 ("Update OpenWrt base")
Signed-off-by: Sven Eckelmann <sven@narfation.org>

oszilloskop added a commit to freifunk-ffm/gluon that referenced this pull request Dec 14, 2016

Merge branch 'v2016.2.x' into dev (14.12.2016)
* v2016.2.x:
  ar71xx-generic: update support list for CPE210/510/...
  docs: feature/roles: remove another outdated sentence
  docs: feature/roles: update outdates site config docs
  ar71xx: fix LEDs and sysupgrade support for TL-WA801ND v3, remove BROKEN
  openwrt: Remove extra soc check in ath79_gpio_output_select (freifunk-gluon#965)
  gluon-mesh-batman-adv-core: respondd: correctly detect lower interface types (freifunk-gluon#954)
  gluon-next-node: fix ebtables rules without next_node.ip4
  kernel: add at803x workaround for sgmii mode (freifunk-gluon#950)
  gluon-core, gluon-setup-mode: fix WAN/LAN assignment on CPE210
  build: clean up postinst scripts after build
  build: fix setting of opkg tmpdir
  docs: user/site: improve mcast_rate description
  ar71xx, ramips: reduce CPU load and flickering on devices using rsslieds
  docs: fix typo in features/wlan-configuration
  ath9k: fix ath9k_hw_gpio_get() to return 0 or 1 on success
  x86: add mmc drivers to generic and 64 subtargets
  x86-64: add pata drivers
  ar71xx-generic: backport region code support for TP-Link TL-WR841ND v11
  linux-firmware: switch back to git protocol from https for download
  docs: user/site: fix typo (freifunk-gluon#924)

oszilloskop added a commit to freifunk-ffm/gluon that referenced this pull request Dec 18, 2016

Merge branch 'dev' into test
* dev: (21 commits)
  ar71xx-generic: add Support for TP-LINK TL-WR940N v4
  ar71xx-generic: update support list for CPE210/510/...
  docs: feature/roles: remove another outdated sentence
  docs: feature/roles: update outdates site config docs
  ar71xx: fix LEDs and sysupgrade support for TL-WA801ND v3, remove BROKEN
  openwrt: Remove extra soc check in ath79_gpio_output_select (freifunk-gluon#965)
  gluon-mesh-batman-adv-core: respondd: correctly detect lower interface types (freifunk-gluon#954)
  gluon-next-node: fix ebtables rules without next_node.ip4
  kernel: add at803x workaround for sgmii mode (freifunk-gluon#950)
  gluon-core, gluon-setup-mode: fix WAN/LAN assignment on CPE210
  build: clean up postinst scripts after build
  build: fix setting of opkg tmpdir
  docs: user/site: improve mcast_rate description
  ar71xx, ramips: reduce CPU load and flickering on devices using rsslieds
  docs: fix typo in features/wlan-configuration
  ath9k: fix ath9k_hw_gpio_get() to return 0 or 1 on success
  x86: add mmc drivers to generic and 64 subtargets
  x86-64: add pata drivers
  ar71xx-generic: backport region code support for TP-Link TL-WR841ND v11
  linux-firmware: switch back to git protocol from https for download
  ...

ecsv added a commit to FreifunkVogtland/gluon that referenced this pull request Jun 9, 2017

openwrt: Remove extra soc check in ath79_gpio_output_select (freifunk…
…-gluon#965)

The  assignment of the gpio_count and reg_base in ath79_gpio_output_select
takes care that only supported platforms can use ath79_gpio_output_select.
But the rebase of the patches after the last OpenWrt base update
accidentally added an extra check for the SoC which was missing support
soc_is_qca955x().

Boots on QCA955X devices which were using ath79_gpio_output_select stopped
with

    Kernel bug detected[#1]:
    [...]
    Call Trace:
    [<803e6174>] ath79_gpio_output_select+0x30/0xe8
    [<803ed590>] om5p_acv2_setup+0x24/0x200
    [<803e4dc0>] ath79_setup+0x28/0x38
    [<80069ac8>] do_one_initcall+0x148/0x1ec
    [<803e2cc4>] kernel_init_freeable+0x150/0x208
    [<80065218>] kernel_init+0x10/0x114
    [<80060878>] ret_from_kernel_thread+0x14/0x1c

Fixes: a22c1d5 ("Update OpenWrt base")
Signed-off-by: Sven Eckelmann <sven@narfation.org>

ecsv added a commit to FreifunkVogtland/gluon that referenced this pull request Jun 9, 2017

openwrt: Remove extra soc check in ath79_gpio_output_select (freifunk…
…-gluon#965)

The  assignment of the gpio_count and reg_base in ath79_gpio_output_select
takes care that only supported platforms can use ath79_gpio_output_select.
But the rebase of the patches after the last OpenWrt base update
accidentally added an extra check for the SoC which was missing support
soc_is_qca955x().

Boots on QCA955X devices which were using ath79_gpio_output_select stopped
with

    Kernel bug detected[#1]:
    [...]
    Call Trace:
    [<803e6174>] ath79_gpio_output_select+0x30/0xe8
    [<803ed590>] om5p_acv2_setup+0x24/0x200
    [<803e4dc0>] ath79_setup+0x28/0x38
    [<80069ac8>] do_one_initcall+0x148/0x1ec
    [<803e2cc4>] kernel_init_freeable+0x150/0x208
    [<80065218>] kernel_init+0x10/0x114
    [<80060878>] ret_from_kernel_thread+0x14/0x1c

Fixes: a22c1d5 ("Update OpenWrt base")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment