Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): update value of suksess color #1614

Merged
merged 2 commits into from Nov 24, 2020
Merged

feat(core): update value of suksess color #1614

merged 2 commits into from Nov 24, 2020

Conversation

piofinn
Copy link
Contributor

@piofinn piofinn commented Nov 18, 2020

📥 Proposed changes

Oppdater verdien av suksess-fargen. NB! Denne må også oppdateres i Figma-biblioteket for å holde oss i synk.

☑️ Submission checklist

  • I have read the CONTRIBUTING doc
  • yarn build works locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

💬 Further comments

affects: @fremtind/jkl-core, @fremtind/portal

@piofinn
feat(core): update value of suksess color
0f284aa 
affects: @fremtind/jkl-core, @fremtind/portal
@piofinn piofinn added ✨ enhancement Forslag til nye funksjoner og endringer 🎨 visuell endring Brukes hvis arbeidet har visuelle endringer labels Nov 18, 2020
@piofinn piofinn self-assigned this Nov 18, 2020
@piofinn
Copy link
Contributor Author

piofinn commented Nov 18, 2020

@Slaine2 eller @Steinop, vil en av dere oppdatere denne i Figma?

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 18, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dc38423:

Sandbox Source
all-components Configuration

@Slaine2
Copy link
Contributor

Slaine2 commented Nov 18, 2020

@piofinn Jeg kan gjøre det i morgen

Steinop
Steinop approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@Steinop Steinop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Har oppdatert grønnfargen i Figmabiblioteket og korrigert til riktig HEX i Figmatooltip

@piofinn piofinn merged commit ffbd0c9 into master Nov 24, 2020
@piofinn piofinn deleted the feat/update-suksess-color branch November 24, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vegardsoerlie vegardsoerlie vegardsoerlie approved these changes

@lfbergee lfbergee lfbergee approved these changes

@Steinop Steinop Steinop approved these changes

@joms joms Awaiting requested review from joms

@Murstam Murstam Awaiting requested review from Murstam

@Slaine2 Slaine2 Awaiting requested review from Slaine2

Assignees

@piofinn piofinn

Labels
✨ enhancement Forslag til nye funksjoner og endringer 🎨 visuell endring Brukes hvis arbeidet har visuelle endringer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@piofinn @Slaine2 @vegardsoerlie @lfbergee @Steinop