From e178e3a197571ae7a720bd6b947be3bb33962f70 Mon Sep 17 00:00:00 2001
From: Jos Warmer <jos.warmer@openmodeling.nl>
Date: Thu, 20 Jun 2024 10:44:06 +0200
Subject: [PATCH] Add todos

---
 packages/core/src/editor/boxes/Box.ts         | 1 +
 packages/core/src/typer/FreTypeOrderedList.ts | 1 +
 packages/core/src/util/FreUtils.ts            | 1 +
 packages/core/src/validator/FreValidator.ts   | 1 +
 4 files changed, 4 insertions(+)

diff --git a/packages/core/src/editor/boxes/Box.ts b/packages/core/src/editor/boxes/Box.ts
index 490f575e6..3c5fd020f 100644
--- a/packages/core/src/editor/boxes/Box.ts
+++ b/packages/core/src/editor/boxes/Box.ts
@@ -103,6 +103,7 @@ export abstract class Box {
         if (this.isLeaf() && this.selectable) {
             return this;
         }
+        // TODO Why filter or concat here?
         const childrenReversed = this.children.filter(ch => true).reverse();
         for (const child of childrenReversed) {
             const leafChild = child.lastLeaf;
diff --git a/packages/core/src/typer/FreTypeOrderedList.ts b/packages/core/src/typer/FreTypeOrderedList.ts
index 4b92c0231..0b3c376af 100644
--- a/packages/core/src/typer/FreTypeOrderedList.ts
+++ b/packages/core/src/typer/FreTypeOrderedList.ts
@@ -9,6 +9,7 @@ export class FreTypeOrderedList<T extends FreType> implements Iterable<T> {
     }
 
     add(p: T, typer: FreTyper) {
+        // TODO Why use typeof
         if (!!typer) {
             if (!this.elements.find(e => typer.equals(e, p))) {
                 this.elements.push(p);
diff --git a/packages/core/src/util/FreUtils.ts b/packages/core/src/util/FreUtils.ts
index 7a11ced5a..68d040f88 100644
--- a/packages/core/src/util/FreUtils.ts
+++ b/packages/core/src/util/FreUtils.ts
@@ -59,6 +59,7 @@ export class FreUtils {
 
     static setContainer(exp: FreNode, freOwnerDescriptor: FreOwnerDescriptor | null, editor: FreEditor): void {
         runInAction(() => {
+            // TODO Why use typeof
             if (!!freOwnerDescriptor) {
                 if (freOwnerDescriptor.propertyIndex === undefined) {
                     freOwnerDescriptor.owner[freOwnerDescriptor.propertyName] = exp;
diff --git a/packages/core/src/validator/FreValidator.ts b/packages/core/src/validator/FreValidator.ts
index 9926ff102..04b79b5ab 100644
--- a/packages/core/src/validator/FreValidator.ts
+++ b/packages/core/src/validator/FreValidator.ts
@@ -34,6 +34,7 @@ export class FreError {
         this.message = message;
         this.reportedOn = node;
         this.locationdescription = locationdescription;
+        // TODO Why use typeof
         if (!!severity) {
             this.severity = severity;
         } else {