minor: setup_configuration() cleanup #1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hroff-1902
force-pushed
the
cleanup-setup-configuration
branch
from
2344ba6
to
195bf5a
Compare
xmatthias
approved these changes
Jun 17, 2019
| assert "exchange" in config | ||
| assert config['exchange']['dry_run'] is True | ||
| assert config['exchange']['key'] == '' | ||
| assert config['exchange']['secret'] == '' |
There was a problem hiding this comment.
On a side note (just realized this now) we should also zero "password" and "uid" here, depending on the exchange these options can be exchange "secrets" too (see exchange.py - L162ff).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dry_run = Trueadded to it;optimize/__init__.pyto avoid duplication of the code;This function is intended for the use in all other new utility subcommands that require configuration in the dry_run mode without real exchange key and secret (i.e. all besides simple list-exchanges which runs without configuration).