Update provider registry and application registry via governance #2587

saraswatpuneet · 2025-09-02T21:16:23Z

Goal

The goal of this PR is to introduce following 4 extrinsic to allow updating provider registry and application contexts

propose_to_update_provider
update_provider_via_governance
propose_to_update_application
update_application_via_governance

Additionally, a create_application extrinsic is introduced to make it easy to create applications for testing and is added in BaseFilter

Closes #2577
Closes #2578

Checklist

codecov · 2025-09-02T21:36:28Z

Codecov Report

❌ Patch coverage is 93.43066% with 9 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
pallets/msa/src/lib.rs	93.43%	9 Missing ⚠️

Files with missing lines	Coverage Δ
pallets/msa/src/migration/v2.rs	`0.00% <ø> (ø)`
pallets/msa/src/lib.rs	`91.74% <93.43%> (+0.57%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aramikm

Overall looks good, added some nits and concerns

aramikm · 2025-09-05T20:04:12Z

runtime/frequency/src/lib.rs

+			// Block `create_provider`, `create_provider_v2`, `create_application` and `create_schema` calls from utility batch
+			RuntimeCall::Msa(pallet_msa::Call::create_provider { .. }) |
 			RuntimeCall::Msa(pallet_msa::Call::create_provider_v2 { .. }) |
+			RuntimeCall::Msa(pallet_msa::Call::create_application { .. }) |


I think the problem with having features on top of extrinsics was that it would modify the extrinsic indices between testnet and mainnet when we didn't have explicit index assignment for each extrinsic.

The other issue is the metadata compatibility. Having metadata for a feature that is disabled is better compared to not having any metadata for it. If we gate extrinisics by feature it would fork metadata into 2 different versions depending on if it was generated for testnet or mainnnet which can also be another pain point in future.

I think if we decide to add feature to these it should probably be inside the extrinsic body and the implementation should be refactored to support this.

pallets/msa/src/benchmarking.rs

aramikm · 2025-09-05T20:59:25Z

pallets/msa/src/lib.rs

+		/// * [`Error::InvalidBCP47LanguageCode`] - If the provided BCP 47 language code is invalid.
+		/// * [`Error::ApplicationNotFound`] - If the application is not registered.
+		#[pallet::call_index(28)]
+		#[pallet::weight(T::WeightInfo::propose_to_update_application())]


nit: does this also need the same benchmark changes?

Proposal does not really change the state but create a proposal and that's it so it's not useful to add or not hence all proposal_* related ones have no parameters

So we use the max payload that can sent to it to compute the best worst estimate

pallets/msa/src/lib.rs

@JoeCap08055

# Details [Design Doc](https://github.com/frequency-chain/frequency/blob/main/designdocs/provider_contexts.md) Provider Context allows provider to now register a minimal profile `ProviderRegistryEntry` and `ApplicationContext` for provider's default profile and various applications providers want to register. Providers which want to register multiple applications under single provider delegation but distributed across multiple app. Following issues were resolved as part of this work with following salient points: 1. Migration existing `ProviderToRegistryEntry` to host new `ProviderRegistryEntry` payload 2. Introduce new state `ProviderToApplicationRegistry` and `ApprovedLogos` storage maps. 3. CID's are computed in deterministic way = `base(cid_v1(sha_256(logo_bytes)))` where logo_bytes are .png image bytes. 4. ApprovedLogos ensure it matches CID and logoBytes but recomputing and checking on chain. Issues complete as part of `Provider Context` work - [x] #2523 - [x] #2524 - [x] #2525 - [x] #2528 - [x] #2526 - [x] #2577 - [x] #2578 Closes #2578 Closes #2577 # Discussion items - [x] Do we feature flag than base filter out extrinsics @JoeCap08055 comment [here](#2587 (comment)) # Checklist - [x] Updated Pallet Readme? - [x] Updated js/api-augment for Custom RPC APIs? - [x] Design doc(s) updated? - [x] Unit Tests added? - [x] e2e Tests added? - [x] Benchmarks added? - [x] Spec version incremented? --------- Co-authored-by: Joe Caputo <joseph.caputo@projectliberty.io> Co-authored-by: Aramik <aramikm@gmail.com> Co-authored-by: Matthew Orris <1466844+mattheworris@users.noreply.github.com>

saraswatpuneet added 2 commits September 2, 2025 16:14

add update_provider_via_governance extrinsic

566faae

provider update related ext

c6a6446

github-actions bot added the metadata-changed Metadata has changed since the latest full release label Sep 2, 2025

add extrinsics to update a given application

ff260b4

github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Sep 2, 2025

saraswatpuneet changed the title ~~[WIP] Update provider registry and application via governance~~ [WIP] Update provider registry and application registry via governance Sep 2, 2025

github-actions bot added the metadata-changed Metadata has changed since the latest full release label Sep 2, 2025

add provider/application update tests

fa1dfcb

github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Sep 3, 2025

add benchmarks and tests

e8d61b7

github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Sep 3, 2025

saraswatpuneet and others added 2 commits September 3, 2025 14:31

Update weights

ce09338

update weights and add e2e tests

02208fe

github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Sep 3, 2025

saraswatpuneet changed the title ~~[WIP] Update provider registry and application registry via governance~~ Update provider registry and application registry via governance Sep 3, 2025

saraswatpuneet marked this pull request as ready for review September 3, 2025 15:07

saraswatpuneet requested a review from wilwade as a code owner September 3, 2025 15:07

saraswatpuneet requested review from a team, JoeCap08055, aramikm, claireclark1, enddynayn, mattheworris and shannonwells and removed request for a team September 3, 2025 15:07

lint e2e

5f47790

github-actions bot added the metadata-changed Metadata has changed since the latest full release label Sep 3, 2025

saraswatpuneet and others added 2 commits September 4, 2025 21:01

Update weights

e7f01ed

set correct weights on extrinsics

d7451c3

github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Sep 4, 2025

saraswatpuneet and others added 2 commits September 4, 2025 21:30

Update weights

1dab27b

fix lint

1fa7330

github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Sep 4, 2025

block on filter

7e40764

github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Sep 4, 2025

remove hidden in test

5680042

github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Sep 5, 2025

saraswatpuneet mentioned this pull request Sep 5, 2025

Provider Context: Minimal Profile for Provider and Applications #2549

Merged

15 tasks

github-actions bot added the metadata-changed Metadata has changed since the latest full release label Sep 5, 2025

update pallet readme with new apis and runtime api

c6a4a74

github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Sep 5, 2025

aramikm approved these changes Sep 5, 2025

View reviewed changes

set proper removabls of older cids from logo storage

6517305

github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Sep 5, 2025

saraswatpuneet and others added 2 commits September 5, 2025 23:50

Update weights

a8643af

better assertions

b944fe8

github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Sep 6, 2025

remove unused variable

267f015

github-actions bot added the metadata-changed Metadata has changed since the latest full release label Sep 6, 2025

saraswatpuneet merged commit 0182963 into feat/provider-context-development Sep 6, 2025
31 of 32 checks passed

saraswatpuneet deleted the 2549_update_provider branch September 6, 2025 00:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update provider registry and application registry via governance #2587

Update provider registry and application registry via governance #2587

Uh oh!

saraswatpuneet commented Sep 2, 2025 •

edited

Loading

Uh oh!

codecov bot commented Sep 2, 2025 •

edited

Loading

Uh oh!

aramikm left a comment

Uh oh!

aramikm Sep 5, 2025

Uh oh!

Uh oh!

aramikm Sep 5, 2025

Uh oh!

saraswatpuneet Sep 5, 2025 •

edited

Loading

Uh oh!

saraswatpuneet Sep 6, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Update provider registry and application registry via governance #2587

Update provider registry and application registry via governance #2587

Uh oh!

Conversation

saraswatpuneet commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Goal

Checklist

Uh oh!

codecov bot commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aramikm left a comment

Choose a reason for hiding this comment

Uh oh!

aramikm Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aramikm Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

saraswatpuneet Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

saraswatpuneet Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

saraswatpuneet commented Sep 2, 2025 •

edited

Loading

codecov bot commented Sep 2, 2025 •

edited

Loading

saraswatpuneet Sep 5, 2025 •

edited

Loading