chore: reuse puppeteer instance#2110
Closed
deer wants to merge 1 commit into
Closed
Conversation
Contributor
|
@lucacasonato is there a way to disable the tracing ops feature of |
Member
|
@marvinhagemeister No. But usually the solution to the sanitizer failing is not to disable the sanitizer, but to fix the test. In this PR for example, you leak |
lucacasonato
reviewed
Dec 1, 2023
| sanitizeOps: false, | ||
| sanitizeResources: false, | ||
| }, async () => { | ||
| await delay(1000); |
Member
There was a problem hiding this comment.
Rather than awaiting on a delay here (flaky), await launchOrGetBrowser()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshing #1418, along with some minimal perf numbers by running
deno test -A tests/partials_test.ts --reporter=dot:before the change
after the change:
So this seems like a sizable improvement. It seems like the test runner doesn't wait for
globalThisto finish doing its thing before starting, so I added some dummy tests at the top of the two modified files to make sure everything is warm before continuing. If there's a better way, please let me know.