Skip to content

fix: allow relative paths for outDir and staticDir#2914

Merged
marvinhagemeister merged 4 commits into
freshframework:mainfrom
csvn:test/config
May 12, 2025
Merged

fix: allow relative paths for outDir and staticDir#2914
marvinhagemeister merged 4 commits into
freshframework:mainfrom
csvn:test/config

Conversation

@csvn

@csvn csvn commented May 10, 2025

Copy link
Copy Markdown
Contributor

This PR consists of several commits, where the goal is to re-enable the test (fix for Windows), as well as allow relative paths for config options to address #2913.

  1. Re-enables test and normalizes paths for Windows
  2. Add unit test for normalizeConfig and the root option
  3. Add unit test for normalizeConfig for build.outDir and staticDir, and allow the properties to be relative
  4. Add JSDoc for fields in FreshConfig

I can split these into separate PR's if preferred, but all code changes are very in nearly the same places.

Closes #2913

@marvinhagemeister marvinhagemeister left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks!

@marvinhagemeister marvinhagemeister merged commit c0e2b80 into freshframework:main May 12, 2025
4 of 7 checks passed
@csvn csvn deleted the test/config branch May 21, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support relative paths for build.outDir and staticDir

2 participants