Skip to content

fix: remove unnecessary config property in init script#2915

Merged
marvinhagemeister merged 1 commit into
freshframework:mainfrom
csvn:fix/tweak-init
May 12, 2025
Merged

fix: remove unnecessary config property in init script#2915
marvinhagemeister merged 1 commit into
freshframework:mainfrom
csvn:fix/tweak-init

Conversation

@csvn

@csvn csvn commented May 10, 2025

Copy link
Copy Markdown
Contributor

From what I can see, fsRoutes uses the FreshConfig.root option by default, so this property does not need to be specified. I also added some JSDoc for the dir option in fsRoutes() as I understood it's purpose.

@marvinhagemeister marvinhagemeister left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marvinhagemeister marvinhagemeister merged commit d10ea5a into freshframework:main May 12, 2025
4 of 7 checks passed
@csvn csvn deleted the fix/tweak-init branch May 21, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants