Skip to content

fix(init): must use urls for asset copying#2946

Merged
marvinhagemeister merged 1 commit into
mainfrom
fix-init-again
May 14, 2025
Merged

fix(init): must use urls for asset copying#2946
marvinhagemeister merged 1 commit into
mainfrom
fix-init-again

Conversation

@marvinhagemeister

@marvinhagemeister marvinhagemeister commented May 14, 2025

Copy link
Copy Markdown
Contributor

Second attempt to fix #2943 . Turns out that import.meta.dirname is undefined when served from JSR. I'm not able to reproduce that error locally though.

Fixes #2943

@marvinhagemeister marvinhagemeister merged commit 1957fd0 into main May 14, 2025
9 of 10 checks passed
@marvinhagemeister marvinhagemeister deleted the fix-init-again branch May 14, 2025 20:59
@csvn

csvn commented May 14, 2025

Copy link
Copy Markdown
Contributor

Turns out that import.meta.dirname is undefined when served from JSR.

Wow, that was news to me too. Is that intended behavior or is a bug? I'm more surprised that import.meta.resolve works compared to dirname 😅

Anyway, thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants