feat[init]: Add "nodeModulesDir": "auto" to the deno.json in the freshv2 init script #2973 #2813#2990
Closed
SisyphusZheng wants to merge 12 commits into
Closed
Conversation
…amework#2973 After initializing a project with the current version v2 alpha-34 and directly running deno task dev, the button in the sample program did not work. However, after adding nodeModulesDir: "auto", it worked normally. Meanwhile, I noticed that there seems to be some problem with the current deno task ok.
csvn
reviewed
May 22, 2025
…phusZheng/fresh into fix(core)init-deno.json-bug
Contributor
Author
|
--patch-1 |
SisyphusZheng
changed the title
SisyphusZheng
changed the title
SisyphusZheng
changed the title
SisyphusZheng
changed the title
marvinhagemeister
pushed a commit
that referenced
this pull request
Aug 15, 2025
- Cleaning up TMP files in CI is unnecessary, as files are discarded automatically between runs (except of using cache/artifacts) - On Windows, `<user>\AppData\Local\Temp\*` files are _not_ automatically removed (see resources below) This PR should make tests a tiny bit faster in CI by avoiding work, as well as skipping error messages that might follow. And running tests locally will now log warnings if temp files fails to be removed instead of silently continuing. ## Resources - https://www.reddit.com/r/windows/comments/yfpbb1/why_arent_windows_temp_files_deleted/ - https://www.reddit.com/r/WindowsHelp/comments/1f4lgui/why_does_windows_cleanup_miss_temp_folder/?utm_source=chatgpt.com <img width="1066" height="1065" alt="image" src="https://github.com/user-attachments/assets/55c98f86-e134-4a2d-86cc-cbab63048c47" /> Partially replaces #2990
Contributor
|
Looks like this was already merged as part of #3054 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue in #2973 appears to be caused by multiple cached versions of dependencies. After directly deleting the ~/.cache/deno directory, the problem was resolved. Enabling nodeModulesDir: "auto" can also avoid this issue. Upon checking the requirement in #2813, it suggests changing "nodeModules": "true" to the recommended "auto" in Fresh v1, while Fresh v2 does not have this setting. Considering these two issues, the configuration in Fresh v1, and future support for Fresh plugins (such as Tailwind v4), I believe adding "nodeModulesDir": "auto" to the init script would be beneficial in many aspects.
Also re-edit the test_utils to add functions for re-deleting the tmp directory and setting timeouts, due to permission issues on Github CI testing in Win env.
Closes #2973
Closes #2813