test: improve temp dir disposal for CI vs Local#3218
Merged
marvinhagemeister merged 1 commit intoAug 15, 2025
Conversation
csvn
commented
Aug 15, 2025
| dir, | ||
| async [Symbol.asyncDispose]() { | ||
| // Skip pointless cleanup in CI, speed up tests | ||
| if (Deno.env.get("CI") === "true") return; |
Contributor
Author
There was a problem hiding this comment.
GitHub Actions (and most other CI tools) sets this to true when run.
| // Ignore errors Files in tmp will be cleaned up by the OS | ||
| // Temp files are not cleaned up automatically on Windows | ||
| // deno-lint-ignore no-console | ||
| console.warn(`Failed to clean up temp dir: "${dir}"`); |
Contributor
Author
There was a problem hiding this comment.
Can be helpful when running locally, because if failing to remove the dirs it may spam the <user>\AppData\Local\Temp dir with new folders on WIndows that are not cleaned up if running consecutive tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<user>\AppData\Local\Temp\*files are not automatically removed (see resources below)This PR should make tests a tiny bit faster in CI by avoiding work, as well as skipping error messages that might follow.
And running tests locally will now log warnings if temp files fails to be removed instead of silently continuing.
Resources
Partially replaces #2990