Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a systemd unit file #1

Merged
merged 2 commits into from Mar 10, 2020
Merged

Provide a systemd unit file #1

merged 2 commits into from Mar 10, 2020

Conversation

@evamvid
Copy link
Contributor

evamvid commented Mar 10, 2020

This is a systemd unit file to allow spotpris2 to be daemonized. I put it in a separate folder in the top-level because it's probably not relevant for people installing out of PyPI, but for the AUR it probably make sense.

@freundTech

This comment has been minimized.

Copy link
Owner

freundTech commented Mar 10, 2020

Looks good. Could you maybe remove remove the Wants=sound.target and After=sound.target lines and add Requires and After lines for dbus.socket?
spotpris doesn't directly interact with anything sound related, so it doesn't need sound (You could for example only use it to control spotify on other devices).

It does however need a dbus daemon running to offer it's mpris interface.

@freundTech freundTech force-pushed the evamvid:master branch from 64b34a7 to 4def72c Mar 10, 2020
@freundTech freundTech merged commit dc62623 into freundTech:master Mar 10, 2020
@freundTech

This comment has been minimized.

Copy link
Owner

freundTech commented Mar 10, 2020

I quickly fixed it myself. Sorry for force pushing to your branch.

Thanks!

@evamvid

This comment has been minimized.

Copy link
Contributor Author

evamvid commented Mar 11, 2020

No worries about the push!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.