Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesh ply files from masif preprocessing scripts were not fed into atoms_to_points_normals #19

Closed
jiyanbio opened this issue Jan 20, 2022 · 1 comment

Comments

@jiyanbio
Copy link

atoms_to_points_normals() function was decrbied clearly in your paper. But the trainning process by using mesh ply files from masif preprocessing scripts skipped it.
My question is that, in the inference step, If such model directly took a pdb as the input which would be convert to points by atoms_to_points_normals() function, does it make sense when input files are different between training and inference?

@FreyrS
Copy link
Owner

FreyrS commented Feb 3, 2022

Hi @jiyanbio,

dMaSIF calls atoms_to_points_normals() also during training and only extracts the interface labels from the mesh ply files.
During training we simplified the process such that the surfaces are only generated before the first epoch and not during every epoch, see

train_dataset = iterate_surface_precompute(train_loader, net, args)
, this line eventually leads to
net.preprocess_surface(P1)
where the surface of each protein is generated.

@FreyrS FreyrS closed this as completed Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants