Move Inline Data Example Into Repository #51

Merged
merged 2 commits into from Apr 21, 2016

Conversation

Projects
None yet
3 participants
Contributor

waylonflinn commented Apr 19, 2016

This adds the recently added test data for inline data elements to the test/fixtures directory.

There's a hidden catch-22 here. The tests won't pass for this PR, until after it's merged. I've done what I can to ensure that they'll work after the merge, but we should stay vigilant shortly after merging to ensure it works.

Contributor

rufuspollock commented Apr 20, 2016

@danfowler could you code review this?

danfowler self-assigned this Apr 20, 2016

Can do.

Contributor

waylonflinn commented Apr 20, 2016

@danfowler a bit of history: this builds on PR #50

Please ignore this comment, if that was obvious.

Contributor

rufuspollock commented Apr 21, 2016

@waylonflinn perfect - thank-you! Merging now.

/cc @danfowler i've now managed to review this so no worries 😄

@rufuspollock rufuspollock merged commit 4d9e65f into frictionlessdata:master Apr 21, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

waylonflinn referenced this pull request in frictionlessdata/datapackage-identifier-js Apr 21, 2016

Merged

Allow Packages in GitHub Subfolders and Branches #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment