Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open from Uploaded File #49

Closed
acouch opened this issue Feb 24, 2019 · 4 comments
Closed

Open from Uploaded File #49

acouch opened this issue Feb 24, 2019 · 4 comments
Assignees
@kmanaseryan @mariorodeghiero

Comments

@acouch
Copy link

acouch commented Feb 24, 2019

When using data.js in the browser it would be useful to be able to open() from using the File interface. Typically files are read with File Reader.

If you need to already parse the file using File Reader or other method then the utility of using data.js is diminished.

I think we could maybe do this by adding a class similar to FileRemote and FileInline that reads the uploaded file data.
This was referenced Mar 3, 2019
Open
Open
@rufuspollock rufuspollock mentioned this issue Aug 23, 2020
Closed
18 tasks
@rufuspollock rufuspollock mentioned this issue Sep 1, 2020
Closed
4 tasks
@mariorodeghiero
Copy link
Contributor

@rufuspollock @kmanaseryan

Update:

@kmanaseryan
Copy link
Member

Blocked by #69

@kmanaseryan kmanaseryan mentioned this issue Sep 7, 2020
Merged
2 tasks
mariorodeghiero added a commit that referenced this issue Sep 8, 2020
@mariorodeghiero
[fix][s]: fix conflicts- #49
836a475
mariorodeghiero added a commit that referenced this issue Sep 8, 2020
@mariorodeghiero
[add][m]: add FileInterface class - #49
087a027 
- add class FIleInterface extends File
- add methods arraybuffer and hash
- fix conflicts
mariorodeghiero added a commit that referenced this issue Sep 8, 2020
@mariorodeghiero
[edit][s]: change the function name - #49
ba9b196
mariorodeghiero added a commit that referenced this issue Sep 8, 2020
@mariorodeghiero
[fix][s]: fix exports correct function name - #49
3b12b15
@mariorodeghiero
Copy link
Contributor

Updates:

kmanaseryan added a commit that referenced this issue Sep 9, 2020
@kmanaseryan
[test][s]: Write a basic test for FileInterface - #49
674cbc8
kmanaseryan added a commit that referenced this issue Sep 9, 2020
@kmanaseryan
[test][s]: Write a basic test for FileInterface - #49
bafeb1b
kmanaseryan added a commit that referenced this issue Sep 9, 2020
@kmanaseryan
[tests][s]: Write tests for testing addSchema() and stream() methods …
180aaf9 
…of file having browser File type - #49
mariorodeghiero added a commit that referenced this issue Sep 10, 2020
@mariorodeghiero
[add][m]: create addSchema for FileInterface class - #49
e92d605 
- fix hash method to work with big files, tested with 1.9Gb
- create data to infer in the schema maximum 100 rows
- create readCSV function for browser to read and parse the data with support for big files without broken the browser
- used tableschema.infer to create the schema
kmanaseryan added a commit that referenced this issue Sep 10, 2020
@kmanaseryan
[test][m]: Integrate Karma and Jasmine for testing in real browser en…
61ba2cb 
…vironement - #49
kmanaseryan added a commit that referenced this issue Sep 10, 2020
@kmanaseryan
[test][xs]: Remove extra row from test file - #49
d2b4983
kmanaseryan added a commit that referenced this issue Sep 11, 2020
@kmanaseryan
[test,ci][s]: Specify browser in Karma test - #49
17ee52f
kmanaseryan added a commit that referenced this issue Sep 11, 2020
@kmanaseryan
[deps][m]: Remove Papaparse and CryptoJS since we don't need them - #49
34ad675
kmanaseryan added a commit that referenced this issue Sep 11, 2020
@kmanaseryan
[test][m]: Update the test to cover hash sha256 and rows() functions - …
298fcf8 
…#49
kmanaseryan added a commit that referenced this issue Sep 11, 2020
@kmanaseryan
[file][m]: Implement rows(), hash(), hashSha256() and make browser fi…
40fdf3c 
…le based resource more closer to the generic interface - #49
anuveyatsu added a commit that referenced this issue Sep 11, 2020
@anuveyatsu
Merge pull request #76 from datopian/feature/open-from-uploaded-file
3d29547 
[test,ci][s]: Specify browser in Karma test - #49
kmanaseryan added a commit that referenced this issue Sep 11, 2020
@kmanaseryan
[test][s]: Test browser file based resource against buffer, stream fu…
13d2cc3 
…nctions - #49
kmanaseryan added a commit that referenced this issue Sep 11, 2020
@kmanaseryan
[readme][s]: Update README explaining how to run tests - #49
03cc97d
anuveyatsu added a commit that referenced this issue Sep 11, 2020
@anuveyatsu
Merge pull request #77 from datopian/feature/open-from-uploaded-file
0d80cd9 
#49 - Rows(), stream(), hashSha256, buffer support
@kmanaseryan
Copy link
Member

FIXED in #76 and #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmanaseryan kmanaseryan

@mariorodeghiero mariorodeghiero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@acouch @kmanaseryan @mariorodeghiero