Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badge should show only the master branch status by default? #332

Open
roll opened this issue Oct 28, 2019 · 3 comments
Labels
bug
Projects

Comments

@roll
Copy link
Member

@roll roll commented Oct 28, 2019

Overview

From @augusto-herrmann

In one of my repos https://github.com/augusto-herrmann/transparencia-dados-abertos-brasil , goodtables validates ok if I am on the master branch: goodtables data/valid/datapackage.json runs without errors. However, I have a few branches in the repo that are expected not to validate -- they're under development. However, the Goodtables.io badge shows as invalid, even when in github I am viewing the master branch. Is that expected behaviour, @roll ?


Please preserve this line to notify @amercader (lead of this repository)

@roll roll added this to Software (wide) in General Oct 28, 2019
@roll

This comment has been minimized.

Copy link
Member Author

@roll roll commented Oct 28, 2019

@amercader
Can you comment on it? I'm not sure

@augusto-herrmann

This comment has been minimized.

Copy link

@augusto-herrmann augusto-herrmann commented Oct 29, 2019

It seems that the badge looks only at the latest commit, regardless of which branch it is.

I've added a new commit to the branch with data that now validates. So now the badge shows the data as valid in all branches.

@roll roll changed the title Branches validation? Badge should show only the master branch status by default? Oct 30, 2019
@roll roll added the bug label Oct 30, 2019
@roll

This comment has been minimized.

Copy link
Member Author

@roll roll commented Oct 30, 2019

It seems a bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
General
  
Software (wide)
2 participants
You can’t perform that action at this time.