New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing dataDependencies for v1 #341

Closed
pwalsh opened this Issue Dec 18, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@pwalsh
Member

pwalsh commented Dec 18, 2016

dataDependencies has an implicit dependency on packages available at data.okfn.org. It is also unclear how a package can depend on other package, which is the main rationale for having the property.

I think this is a potentially powerful feature, but, in the absence of an actual use case, and the ambiguity of the property and how it should be implemented, I suggest we remove it from v1.

We also should allow dependencies to live at any URI, and not only be identifiers for packages on data.okfn.org

@rufuspollock

This comment has been minimized.

Show comment
Hide comment
@rufuspollock

rufuspollock Dec 18, 2016

Contributor

@pwalsh i agree. Let's remove this and reintroduce as a pattern for now.

Contributor

rufuspollock commented Dec 18, 2016

@pwalsh i agree. Let's remove this and reintroduce as a pattern for now.

@pwalsh

This comment has been minimized.

Show comment
Hide comment
@pwalsh

pwalsh Feb 5, 2017

Member

We won't merge #337 until we can support all the changes in the core implementations we maintain. So closing this as it is implemented in #337 , as leaving it open creates confusion.

Member

pwalsh commented Feb 5, 2017

We won't merge #337 until we can support all the changes in the core implementations we maintain. So closing this as it is implemented in #337 , as leaving it open creates confusion.

@pwalsh pwalsh closed this Feb 5, 2017

@rufuspollock rufuspollock referenced this issue May 24, 2017

Closed

[epic] Reintroduce readable style for specs #420

17 of 19 tasks complete
@smartcaveman

This comment has been minimized.

Show comment
Hide comment
@smartcaveman

smartcaveman Jul 23, 2017

If dataDependencies is deprecated, Is there a revised protocol for referencing dependent data packages?

smartcaveman commented Jul 23, 2017

If dataDependencies is deprecated, Is there a revised protocol for referencing dependent data packages?

@rufuspollock

This comment has been minimized.

Show comment
Hide comment
@rufuspollock

rufuspollock Jul 24, 2017

Contributor

@smartcaveman i'd suggest still using dataDependencies - it just isn't an official part of the v1.0 spec - but it is a pattern and is up for inclusion in v1.1 assuming enough interest.

Contributor

rufuspollock commented Jul 24, 2017

@smartcaveman i'd suggest still using dataDependencies - it just isn't an official part of the v1.0 spec - but it is a pattern and is up for inclusion in v1.1 assuming enough interest.

@rufuspollock

This comment has been minimized.

Show comment
Hide comment
Contributor

rufuspollock commented Oct 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment