New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types related to year start with 'g' #346

Closed
tredoe opened this Issue Dec 20, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@tredoe

tredoe commented Dec 20, 2016

Why the field types gyear and gyearmonth start with character 'g' ?

If the other types related to dates are named like date, time, datetime, then it makes not sense to name to those like gyear and gyearmonth.

@rufuspollock

This comment has been minimized.

Show comment
Hide comment
@rufuspollock

rufuspollock Dec 21, 2016

Contributor

@tredoe because it is following xsd types on this and that uses gyear (and the w3c spec followed xsd). I get it is kind of weird and maybe we should just do it simpler given we don't really follow the xsd types generally.

@pwalsh any thoughts on this?

Contributor

rufuspollock commented Dec 21, 2016

@tredoe because it is following xsd types on this and that uses gyear (and the w3c spec followed xsd). I get it is kind of weird and maybe we should just do it simpler given we don't really follow the xsd types generally.

@pwalsh any thoughts on this?

@pwalsh

This comment has been minimized.

Show comment
Hide comment
@pwalsh

pwalsh Dec 21, 2016

Member

@rufuspollock I say we drop the g prefixes.

Member

pwalsh commented Dec 21, 2016

@rufuspollock I say we drop the g prefixes.

@pwalsh pwalsh added the Table Schema label Feb 5, 2017

@pwalsh pwalsh added this to the v1.1 milestone Feb 5, 2017

@roll

This comment has been minimized.

Show comment
Hide comment
@roll

roll Feb 5, 2017

Member

@pwalsh
It's breaking. Also not really implemented anywhere - why don't change it now?

Member

roll commented Feb 5, 2017

@pwalsh
It's breaking. Also not really implemented anywhere - why don't change it now?

@rufuspollock

This comment has been minimized.

Show comment
Hide comment
@rufuspollock

rufuspollock Feb 5, 2017

Contributor

@pwalsh @roll i agree we do this now if we can. It can be a super small PR after the mega PR lands ...

Contributor

rufuspollock commented Feb 5, 2017

@pwalsh @roll i agree we do this now if we can. It can be a super small PR after the mega PR lands ...

@pwalsh pwalsh self-assigned this Feb 5, 2017

@pwalsh pwalsh modified the milestones: v1.0, v1.1 Feb 5, 2017

rufuspollock added a commit that referenced this issue Feb 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment