Fix ThumbRelocator IT block eoi logic #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! What does this solve for you? |
|
I add a test about it. |
|
@bet4it Thanks! I'm afraid this results in failing test(s) in the Stalker ARM32 test-suite. You can run it like this: |
|
I don't have macOS, sad😅 frida-gum/tests/run-android-arm.sh Line 10 in 5888845 |
|
@bet4it Replace that with linux if you're on Linux. It's a (bit too) dumb script 😄 |
bet4it
changed the title
|
Now all the tests have passed. What do you think about it? |
oleavr
changed the title
Instructions inside the block should not result in eoi.
|
Thanks! (Merged with a few minor style tweaks.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just borrow the variable
self->it_block.activeas a flag.