codegen: Plug leak in server-side GDBus reply handling

oleavr · oleavr · commit d07b689485b3 · 2022-06-17T20:53:53.000+02:00
Introduced by me when optimizing the reply handling in 74a66f9. Kudos to @rev1si0n for reporting and helping track this one down.
diff --git a/codegen/valagdbusservermodule.vala b/codegen/valagdbusservermodule.vala
@@ -480,6 +480,10 @@ public class Vala.GDBusServerModule : GDBusClientModule {
 
 		if (ready_data_expr != null && !ready) {
 			ccode.open_if (new CCodeIdentifier ("_fire_and_forget"));
+
+			var unref_call = new CCodeFunctionCall (new CCodeIdentifier ("g_object_unref"));
+			unref_call.add_argument (new CCodeMemberAccess.pointer (ready_data_expr, "_invocation_"));
+			ccode.add_expression (unref_call);
 		}
 
 		foreach (Parameter param in m.get_parameters ()) {

Original file line number	Diff line number	Diff line change
`@@ -480,6 +480,10 @@ public class Vala.GDBusServerModule : GDBusClientModule {`
`480`	`480`
`481`	`481`	`if (ready_data_expr != null && !ready) {`
`482`	`482`	`ccode.open_if (new CCodeIdentifier ("_fire_and_forget"));`
	`483`	`+`
	`484`	`+ var unref_call = new CCodeFunctionCall (new CCodeIdentifier ("g_object_unref"));`
	`485`	`+ unref_call.add_argument (new CCodeMemberAccess.pointer (ready_data_expr, "_invocation_"));`
	`486`	`+ ccode.add_expression (unref_call);`
`483`	`487`	`}`
`484`	`488`
`485`	`489`	`foreach (Parameter param in m.get_parameters ()) {`