Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healthcheck #231

Closed
ne20002 opened this issue Jul 25, 2023 · 3 comments
Closed

Healthcheck #231

ne20002 opened this issue Jul 25, 2023 · 3 comments
Labels
Enhancement New feature or request

Comments

@ne20002
Copy link
Contributor

ne20002 commented Jul 25, 2023

Seems as if Docker is supporting an extra entry point for health checks. It would be nice to have this implemented for fpm and for cron usage of image.
For fpm: check for system answering a simple request
For cron: check if cron is running

@MrPetovan MrPetovan added the Enhancement New feature or request label Jul 25, 2023
@petersem
Copy link

+1

@nupplaphil
Copy link
Collaborator

hm .. I found a similar approach here: https://www-apps.univ-lehavre.fr/forge/ba160129/fullstack-lab/-/commit/55fa7b41f613b7889cfd2b9a17d6433e540c9cfa

It uses the php-fpm ping-endpoint to check the healthiness.

But we will need to split the approach inside the images between php-fpm and cron, which adds additional complexity. I have to think about it :)

@nupplaphil
Copy link
Collaborator

nupplaphil commented Mar 10, 2024

Ok, I'm closing this issue because Friendica is an official image and thus healthchecks are not allowed:

https://github.com/docker-library/faq#healthcheck :

Explicit health checks are not added to official images for a number of reasons, some of which include:

  • many users will have their own idea of what "healthy" means and credentials change over time making generic health checks hard to define
  • after upgrading their images, current users will have extra unexpected load on their systems for healthchecks they don't necessarily need/want and may be unaware of
  • Kubernetes does not use Docker's heath checks (opting instead for separate liveness and readiness probes)
  • sometimes things like databases will take too long to initialize, and a defined health check will often cause the orchestration system to prematurely kill the container (Detecting container initialization on DATADIR is fragile docker-library/mysql#439)

The docker-library/healthcheck repository is to serve as an example > for creating your own image derived from the prototypes present. They serve to showcase the best practices in creating your own healthcheck for your specific task and needs.

@nupplaphil nupplaphil closed this as not planned Won't fix, can't repro, duplicate, stale Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants