Wrong permissions to photos in PMs

[tobiasd]

@ben-utzer reported in the support forum that the permissions of newly uploaded photos in private messages don't get the correct permissions in the current 2018.08-RC code.

Additionally the reader of a PM don't get remote authed when opening the PM so that the image permissions have to be set to public manually after the sending of the PM so that the image can be viewed in the PM by the receiver.

Followup to #5544

[annando]

This isn't coded at all and it could mean much work to implement it. I would prefer just to hide the functionality to post pictures than to add this whole functionality.

[tobiasd]

As the initial problem was fixed with this milestone, I'd rather prefer it really fixed then totally useless as it is at the moment.

[annando]

The problem is that it can get really complicated to solve and test. So this could easily move the whole release some time in the future - and this is time that we then don't have for things like AP. Since now I heard that Mastodon will remove OStatus in the beginning of the next year, I really would prefer having more time for AP.

At this time of the RC, we really shouldn't add complicated things any more, since we don't have much time testing it.

[tobiasd]

Then we should remove this feature from the UI until it is fixed. At the moment it is totally broken and useless and in this state a blocker.

[annando]

I tried to find the Javascript that does invoke the picture browser. I haven't found it. When we want to replace the picture browser with a button that simply adds [img][/img], then someone else has got to do it.

[MrPetovan]

Just remove the button for this release.

[annando]

No. Before the change, the button just inserted that [img][/img] - which I would like to keep. I guess that @rabuzarus can help in finding the call.

[rabuzarus]

hmm difficult. Here is the js code for inserting bbcode formations. This code opens also the image browser when the element which should be inserted is the img bbtag. (https://github.com/friendica/friendica/blob/develop/view/js/main.js#L80)

[annando]

The workaround is ugly - but working.

[MrPetovan]

Moving milestone then. There's only the relationship issue to go before we can wrap up this release.

[annando]

This is now coded, need some testing.

[tobiasd]

Tests are under way...

[tobiasd]

Works at least between RC and RC, locally and remote.