New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second edit of a comment disappears after page refresh #6416

Open
joysfera opened this Issue Jan 9, 2019 · 2 comments

Comments

3 participants
@joysfera
Copy link

joysfera commented Jan 9, 2019

Expected behavior

An edited comment stays the way it was saved.

Actual behavior

Second time edited comment is replaced by previous version after a moment and a page refresh.

Steps to reproduce the problem

Comment something and include a smiley there.
Edit that comment and notice the smiley is still a smiley. Save. Everything's OK.
Edit the same comment again. Notice the smiley is no longer a smiley but an URL to a GIF wrapped in the IMG tags. Check Preview before saving - it looks OKish. Save the comment. It still looks OK.
Now wait about 30 seconds and then refresh the page. The latest version of the comment is gone, it's been replaced quietly by the previous version.

This is the very comment used for reproducing the issue just to document it here:
https://nerdica.net/display/a85d7459-215c-363d-1f4b-e33551528151

here's a screenshot how it looked after the second edit and before the page refresh:
second_edit

Please note that I've encountered the very same situation with posts themselves as well but I when I tried to reproduce it I was not successful so there's some race condition perhaps, some timeouts or caches involved and while testing it I didn't do it exactly the way that triggers the error. With the comments it seems to be reproducible easily.

Friendica version you encountered the problem

2018.12-rc

see example.com/friendica on your Friendica node for the version information.

Friendica source (git, zip)

nerdica.net admin would know it

PHP version

nerdica.net admin would know it

SQL version

nerdica.net admin would know it

@tobiasd

This comment has been minimized.

Copy link
Collaborator

tobiasd commented Jan 10, 2019

Have you written a sigle emoji character (e.g. from the Android keyboard) or did you write something like :-).

@joysfera

This comment has been minimized.

Copy link

joysfera commented Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment