Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose - Send a new message without refreshing wall #8127

Closed
valvin1 opened this issue Jan 18, 2020 · 8 comments
Closed

Compose - Send a new message without refreshing wall #8127

valvin1 opened this issue Jan 18, 2020 · 8 comments
Labels

Comments

@valvin1
Copy link

@valvin1 valvin1 commented Jan 18, 2020

I think there is already an issue about it but I've not found it back.

If there is a feature I would love having on Friendica it is the possibility to send / repost a message without loosing the position of my timeline.

I know there is a workaround by limiting the number of message displayed in one page but it is not what I'd like.

It looks like things happen in Compose items. If I've well understood there is compose.tpl which interacts with compose.js from theme. And finally Compose.post().

What are the other object to check before trying to implement this kind of feature?

@MrPetovan

This comment has been minimized.

Copy link
Collaborator

@MrPetovan MrPetovan commented Jan 18, 2020

Actually, the best way to achieve this goal is to make the JOT modal on frio not refresh the page. The compose page is a separate page, so it would be challenging to keep your position in the timeline, especially with infinite scroll. This is already described in #4599

@valvin1

This comment has been minimized.

Copy link
Author

@valvin1 valvin1 commented Jan 19, 2020

I remember comment this issue but wasn't able to find it back :)

Thank you for explanation so the challenge is more : Remove the form in jot.tpl file here and replacing it with an asynchronous call.

@MrPetovan

This comment has been minimized.

Copy link
Collaborator

@MrPetovan MrPetovan commented Jan 19, 2020

The form can stay, but it would be better handled with Javascript (with FormData for example)

@annando

This comment has been minimized.

Copy link
Collaborator

@annando annando commented Jan 19, 2020

Whatever we do, we should keep the accessibility in mind.

@MrPetovan

This comment has been minimized.

Copy link
Collaborator

@MrPetovan MrPetovan commented Jan 19, 2020

Not sure about it since we're already using a modal but it is a good reminder nonetheless.

@MrPetovan

This comment has been minimized.

Copy link
Collaborator

@MrPetovan MrPetovan commented Jan 30, 2020

Duplicate of #4599

@MrPetovan MrPetovan marked this as a duplicate of #4599 Jan 30, 2020
@MrPetovan MrPetovan closed this Jan 30, 2020
@hoergen

This comment has been minimized.

Copy link
Collaborator

@hoergen hoergen commented Feb 3, 2020

So great improvement! I always opened a new tab in firefox to write a post to not lose the position ;) Thanks a lot 🎉👍🌻

@MrPetovan

This comment has been minimized.

Copy link
Collaborator

@MrPetovan MrPetovan commented Feb 3, 2020

I know, it’s so much more comfortable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.