Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fixes in diabook-derivates #128

Merged
merged 1 commit into from Mar 12, 2012

Conversation

3 participants
Collaborator

tomtom84 commented Mar 12, 2012

fix css

tomtom84 added a commit that referenced this pull request Mar 12, 2012

Merge pull request #128 from tomtom84/master
fixes in diabook-derivates

@tomtom84 tomtom84 merged commit 691f5b1 into friendica:master Mar 12, 2012

Could you please stop using pull requests to push to this repository? It really clutters the project feed, the pull request archive and the git history.

Collaborator

tomtom84 commented Mar 13, 2012

oh, i am sry, if i messed up something... i am quite new to git, but as far as i understood i should push my changes to my fork tomtom84/friendica and send a pull request to friendica/friendica ... how is the way me or somebody else merge my changes into friendica/fiendica ? thx for hints :-)

If you want someone else to merge, pull requests are great. But if you are going to merge your commits immediately anyway, I see no reason for doing a pull request. You can instead directly push to this repository. But maybe there is a project guideline I’m not aware of?

Collaborator

ericcotelnu commented Mar 15, 2012

the project lead hasn't mentioned anything about this. so until they say so otherwise, i'm not going to stop doing so. all the other committers do it like this as well, AFAIK.

there are a few commits i haven't done a pull request, but they were minor changes.

Collaborator

tomtom84 commented Mar 15, 2012

@simonlnu +1

Instead of just following authorities you could think yourself. I for one will stop watching this great project, because I don’t want to read three feed reader items for every single, simple commit you make.

Collaborator

ericcotelnu commented Mar 15, 2012

has nothing to do with whether or not i think for myself, it has to do with working as a team.

sure, i could act as if this project is in a void, but then what would the founder think? what would the other contributors think? i don't think they'd appreciate that. if you have a problem with that, that's your thing. i could just go ahead and decide "very small commits, e.g. 1-10 lines in a 1 file, i won't bother making a pull request". that's logical, but as we up until now having done it this way, and haven't decided - as a group - how to act, this is how i'm going to do things.

do not let my own words speak for the project, i only speak for myself. i only represent myself in this. if others wish to follow the example, that's for them to decide. they could also decide i'm full of it, but i would appreciate them tell me ;-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment