New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings #5338

Merged
merged 6 commits into from Jul 8, 2018

Conversation

3 participants
@annando
Collaborator

annando commented Jul 8, 2018

This is some work in progress. I guess I will work on it for some hours. But due to the annoying mass of warnings, possibly someone wants to accept the PR at some time. Then I will continue the work on following PRs, until all warnings are gone.

annando added some commits Jul 8, 2018

@@ -721,6 +721,7 @@ function conversation(App $a, $items, $mode, $update, $preview = false, $order =
continue;
}
$arr = ['item' => $item];

This comment has been minimized.

@MrPetovan

MrPetovan Jul 8, 2018

Collaborator

This fixes the warning but doesn't fix the wrong Addon::callHooks call. See #5335 (comment)

This comment has been minimized.

@annando

annando Jul 8, 2018

Collaborator

I'm not totally sure if we have to remove the addon call or not. I would suggest checking it at some later time, since there is still much work to do.

This comment has been minimized.

@MrPetovan

MrPetovan Jul 8, 2018

Collaborator

No problem, we'll leave the other issue open.

@MrPetovan

This comment has been minimized.

Collaborator

MrPetovan commented Jul 8, 2018

Thanks for your work, you can go on in this PR or another one.

@annando

This comment has been minimized.

Collaborator

annando commented Jul 8, 2018

If you want to accept this PR now, I will create some additional PR. I'm not done yet, but this will remove most stuff in the logs.

@MrPetovan MrPetovan added the Bug label Jul 8, 2018

@MrPetovan MrPetovan added this to the 2018.08 milestone Jul 8, 2018

@MrPetovan MrPetovan merged commit 7211fc4 into friendica:develop Jul 8, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@annando annando deleted the annando:warnings branch Jul 8, 2018

@tobiasd

This comment has been minimized.

Collaborator

tobiasd commented on view/theme/vier/theme.php in 3e79754 Jul 9, 2018

One of these changes has broken the feature of vier to move the forum widget from the left to the right aside when enough space is available due browser window width.

@tobiasd

This comment has been minimized.

Collaborator

tobiasd commented Jul 9, 2018

It is the additional if (!empty($a->argv[0]) && !empty($a->argv[1])) { when this is commented out, then the feature works as expected.

@annando

This comment has been minimized.

Collaborator

annando commented Jul 9, 2018

Okay, will be fixed in the upcoming PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment