Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples #177

Merged
merged 4 commits into from May 10, 2017

Conversation

Projects
None yet
4 participants
@jackTheRipper
Copy link
Contributor

commented May 2, 2017

Fix some warnings in the Kitchensink
Fix the counter example

@fahad19 @alexmiranda @AlexDudar : could we remove the multiple widget? The functionality it demonstrates is implemented in the kitchensink

@fahad19 @alexmiranda : what do we do regarding the React specific warnings? (createClass)

@coveralls

This comment has been minimized.

Copy link

commented May 2, 2017

Coverage Status

Coverage remained the same at 97.363% when pulling 8dc70ea on fix-examples into a87fd6e on master.

jbaudin
@coveralls

This comment has been minimized.

Copy link

commented May 2, 2017

Coverage Status

Coverage remained the same at 97.363% when pulling aace142 on fix-examples into a87fd6e on master.

@@ -47,3 +47,13 @@
}
window['FrintReact'] = m;
})();

// frint-store
(function () {

This comment has been minimized.

Copy link
@fahad19

fahad19 May 2, 2017

Member

can this file have deps defined in a more readable way? like:

window._ = require('lodash');
window.FrintStore = require('frint-store');

This comment has been minimized.

Copy link
@jackTheRipper

jackTheRipper May 3, 2017

Author Contributor

Sure but following what we discussed yesterday I will do it for the kitchensink.

@fahad19

fahad19 approved these changes May 4, 2017

@jackTheRipper jackTheRipper merged commit 8fd21ed into master May 10, 2017

5 checks passed

Node Security No known vulnerabilities found
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.363%
Details

@fahad19 fahad19 deleted the fix-examples branch May 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.