Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .gitignore to ignore all JetBrains IDEs files under .idea folder #329

Merged
merged 1 commit into from Oct 4, 2017
Merged

Update .gitignore to ignore all JetBrains IDEs files under .idea folder #329

merged 1 commit into from Oct 4, 2017

Conversation

viacheslaff
Copy link
Contributor

Officially JetBrains suggests to add only certain files to .gitignore file: https://github.com/github/gitignore/blob/master/Global/JetBrains.gitignore

There're quite some files it doesn't cover. For example in my case:

.idea/codeStyleSettings.xml
.idea/frint.iml
.idea/inspectionProfiles/Project_Default.xml
.idea/misc.xml
.idea/modules.xml
.idea/preferred-vcs.xml
.idea/vcs.xml

I think since we're all using different IDEs there's no point of adding any files from .idea folder to the project.

@viacheslaff viacheslaff requested review from mAiNiNfEcTiOn and a team October 4, 2017 08:43
discosultan
discosultan approved these changes Oct 4, 2017
View reviewed changes
Copy link
Contributor

@discosultan discosultan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree! 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.277% when pulling 4ac4498 on webstorm-gitignore into 33a02e7 on master.

@viacheslaff viacheslaff merged commit bb1bd61 into master Oct 4, 2017
@viacheslaff viacheslaff deleted the webstorm-gitignore branch October 4, 2017 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fahad19 fahad19 fahad19 approved these changes

@discosultan discosultan discosultan approved these changes

@mAiNiNfEcTiOn mAiNiNfEcTiOn Awaiting requested review from mAiNiNfEcTiOn

Assignees

@viacheslaff viacheslaff

Labels
patch PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@viacheslaff @coveralls @fahad19 @discosultan