Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App: new `setRegions` method #37

Merged
merged 2 commits into from Oct 31, 2016

Conversation

Projects
None yet
5 participants
@fahad19
Copy link
Member

commented Oct 30, 2016

What's done

  • Introduced new setRegions method, accepting multiple Region names
  • Existing setRegion still exists, and calls setRegions internally.

Note: not a breaking change. done mainly to be more in line with the app.manifest file, which stores the region names as an array under targetContainers key.

@fahad19 fahad19 self-assigned this Oct 30, 2016

@alexmiranda
Copy link
Contributor

left a comment

👍 LGTM

@coveralls

This comment has been minimized.

Copy link

commented Oct 30, 2016

Coverage Status

Coverage increased (+0.1%) to 90.299% when pulling f031cd6 on set-regions into 51f79ee on master.

@fahad19 fahad19 merged commit 4aae76c into master Oct 31, 2016

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 90.299%
Details

@fahad19 fahad19 added the minor label Oct 31, 2016

@fahad19 fahad19 deleted the set-regions branch Dec 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.