Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error if preset doesn't return mandatory information #138

Closed
frinyvonnick opened this issue Nov 12, 2019 · 6 comments
Closed

Throw an error if preset doesn't return mandatory information #138

frinyvonnick opened this issue Nov 12, 2019 · 6 comments
Labels
bug Something isn't working
Milestone

Comments

@frinyvonnick
Copy link
Owner

It should throw an error if preset doesn't return mandatory information. Especially if project's current version is missing.

@frinyvonnick frinyvonnick added the bug Something isn't working label Nov 12, 2019
@frinyvonnick frinyvonnick added this to the Roadmap milestone Nov 12, 2019
@bpetetot
Copy link
Collaborator

Just be aware that it's a functional error and don't need to be reported with the new unexpected error report.
Maybe give message to "Check the version in the package.json" in case of node preset and also propose to execute the interactive mode.

@frinyvonnick
Copy link
Owner Author

Sure this is a functional error 😄 I don't understand the point with interactive mode? What do you think of having a generic error to keep preset implementation simple?

@bpetetot
Copy link
Collaborator

bpetetot commented Nov 13, 2019

I made a mistake, I wasn't thinking of interactive mode but propose to do the command:
gitmoji-changelog 1.0.0 if we cannot retrieve the version.

Indeed a generic message like "Cannot retrieve the version from your configuration. Check it or you can do gitmoji-changelog <version>" can be enough.

@frinyvonnick
Copy link
Owner Author

That is what I had in mind 👍

@frinyvonnick
Copy link
Owner Author

Issue #159 is related to this issue

@frinyvonnick
Copy link
Owner Author

Done in #161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants