Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use presets to be independent from the package.json #85

Closed
frinyvonnick opened this issue Jun 2, 2019 · 1 comment · Fixed by #128

Comments

@frinyvonnick
Copy link
Owner

@frinyvonnick frinyvonnick commented Jun 2, 2019

git-repo-info seems to be the solution. We need to figure out if it fullfills all our needs

@frinyvonnick frinyvonnick added this to the 2.0 milestone Jun 2, 2019
@bpetetot

This comment has been minimized.

Copy link
Collaborator

@bpetetot bpetetot commented Jul 9, 2019

To be independent from the package.json we need to:

  • Add a CLI option --preset=node when you want to be based on a package.json
  • Create a module presets/node-preset
  • Preset module has a default exported function that must return an object containing all necessary information extracted (ex: name, version)

In addition, all repository information must be independent from the preset, and only based on the git local. To do it we recommend to use:

@bpetetot bpetetot changed the title Find a get repo info instead of a get pkg info Use presets to be independent from the package.json Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.