New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable tests against SQLite on travis #82

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@simbabque

simbabque commented May 29, 2017

Commit 123fa4a has disabled the possiblity to pass in a connect_info when the creation of that property was moved from the default handler into A::Util along with the call to it in connect(), which was also moved to A::Util. When connect_info is passed to the test object it is now never used, because it does not get handed on to the A::Util::connect call that happens in the builder for schema.

It would be nicer to have the tests default to SQLite without needing an environment variable, but the current architecture in A::Util makes that tricky without changing too much. This change removes unused code and leaves the current behavior untouched.


I found this when looking at the coverage report, specifically the yellow file Explain.pm. A further look at travis revealed that the tests using sqlite in ::Explain never get executed.

This is my entry for the Pull Request Challenge 2017 in May.

enable tests against SQLite on travis
Commit 123fa4a has disabled the possiblity to pass in a connect_info when the creation of that property was moved from the default handler into A::Util along with the call to it in connect(), which was also moved to A::Util. When connect_info is passed to the test object it is now never used, because it does not get handed on to the A::Util::connect call that happens in the builder for schema.

It would be nicer to have the tests default to SQLite without needing an environment variable, but the current architecture in A::Util makes that tricky without changing too much. This change removes unused code and leaves the current behavior untouched.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 29, 2017

Coverage Status

Coverage increased (+0.2%) to 98.638% when pulling cede81d on simbabque:sqlite-tests into 1445098 on frioux:master.

coveralls commented May 29, 2017

Coverage Status

Coverage increased (+0.2%) to 98.638% when pulling cede81d on simbabque:sqlite-tests into 1445098 on frioux:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment