Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial AppVeyor config #11

Merged
merged 1 commit into from Dec 4, 2018

Conversation

@paultcochrane
Copy link
Contributor

@paultcochrane paultcochrane commented Dec 4, 2018

This patch adds a config for the AppVeyor continuous integration service which allows dists to be tested on Windows. it is based upon the AppVeyor CI Helpers for Perl project, which seems to be quite similar to the Travis-CI Perl helpers used in the Travis config in this dist. The current configuration is able to test Perl versions 5.10 .. 5.28, however in order to get these versions to work, it was necessary to extend the base AppVeyor CI Helpers config slightly:

  • currently only Module::Build and ExtUtils::MakeMaker are directy supported in the helper scripts. It turned out that the standard config worked for Perls 5.14+, but in order to get 5.10 and 5.12 working, it was necessary to explicitly install the dependencies listed in the cpanfile via cpanm (see line 123). Long term, it would probably be better to get the helper scripts to automatically work out if a cpanfle exists and then to install things in the appropriate manner, however this patch gets the ball rolling for Syntax::Keyword::Junction.
  • Sub::Exporter was missing from Perl 5.10 and 5.12, hence it is installed as an explicit extra dependency (see the DIST_EXTRA_DEPS variable). It also turned out that at least version 0.986 of Sub::Exporter was required in order that Perls 5.14 and 5.16 also built and tested correctly after adding this dependency. It's unclear if Sub::Exporter should also be mentioned explicitly in the cpanfile; if you'd like that to be added, just let me know and I'll provide a patch.
  • Perl 5.8 can't be built since it requires Variable::Magic which uses XS in the backend and doesn't build cleanly on the AppVeyor infrastructure.

This PR is submitted in the hope that it is helpful; it definitely shows that the dist builds and tests correctly on Windows systems and is thus a starting point for an improved patch if so desired. If you'd like anything changed or updated in this PR, please simply let me know and I'll happily make the changes and resubmit as necessary.

@coveralls
Copy link

@coveralls coveralls commented Dec 4, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling ee417fe on paultcochrane:pr/add-appveyor-config into 3ebc60c on frioux:master.

4 similar comments
@coveralls
Copy link

@coveralls coveralls commented Dec 4, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling ee417fe on paultcochrane:pr/add-appveyor-config into 3ebc60c on frioux:master.

@coveralls
Copy link

@coveralls coveralls commented Dec 4, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling ee417fe on paultcochrane:pr/add-appveyor-config into 3ebc60c on frioux:master.

@coveralls
Copy link

@coveralls coveralls commented Dec 4, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling ee417fe on paultcochrane:pr/add-appveyor-config into 3ebc60c on frioux:master.

@coveralls
Copy link

@coveralls coveralls commented Dec 4, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling ee417fe on paultcochrane:pr/add-appveyor-config into 3ebc60c on frioux:master.

@frioux frioux merged commit 68cf9d7 into frioux:master Dec 4, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@frioux
Copy link
Owner

@frioux frioux commented Dec 4, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants