New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quieten perlcritic's stringy eval warnings #17

Merged
merged 1 commit into from Dec 22, 2018

Conversation

Projects
None yet
3 participants
@paultcochrane
Copy link
Contributor

paultcochrane commented Dec 9, 2018

... since in this case the use of string eval is intentional and hence
it isn't helpful for perlcritic to flag these instances as being
problematic.

If you need anything changed in this PR, please let me know and I'll be happy to update and resubmit as appropriate.

Quieten perlcritic's stringy eval warnings
... since in this case the use of string eval is intentional and hence
it isn't helpful for perlcritic to flag these instances as being
problematic.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 9, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 60094ee on paultcochrane:pr/quieten-perlcritic-stringy-eval-warnings into d8ea8e8 on frioux:master.

@frioux frioux merged commit 2289d05 into frioux:master Dec 22, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment